From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B54D31FA8 for ; Thu, 27 Jul 2023 15:51:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91ACB26BC; Thu, 27 Jul 2023 08:51:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=whKeVZWLhmUYByq+U/YnOMvphcGTOrmTTlmTUFROnf0=; b=boxukzui/wv967gWjsN1nu1vL8 BbCpncLGebuycMF8caT1clC2fsrYVjiVM2mc73Opka5/x758sffC01xiM2lgIPMU7frfQ4an8355L 6+cYY589IjVE6RaneL/6XS4S7mPu9V8ToD7AIcDHPMKgNE1TRdiz99eJrk6NwcR29dszNgH5KzV95 Zng3e1ahmT86WH2d71zAVZAaZi6NxUvKJv9JemqyJAnAUuB+C4nVfSTBVhORdn9XVkr+ti2OUmFRK P+afcJV6rmETsrWIsClJ92ibmNFp+TtQ6wTN+o+L23yUuHRnpRejf2FVeu34FxgLQMai+yYiG4uJN FDfIH3ZQ==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qP3GL-00G8P5-09; Thu, 27 Jul 2023 15:50:49 +0000 Date: Thu, 27 Jul 2023 08:50:49 -0700 From: Luis Chamberlain To: Joel Granados Cc: Joerg Reuter , Ralf Baechle , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , willy@infradead.org, keescook@chromium.org, josh@joshtriplett.org, linux-hams@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 09/14] ax.25: Update to register_net_sysctl_sz Message-ID: References: <20230726140635.2059334-1-j.granados@samsung.com> <20230726140635.2059334-10-j.granados@samsung.com> <20230727153804.vjsofabjbkkfat25@localhost> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230727153804.vjsofabjbkkfat25@localhost> Sender: Luis Chamberlain X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Thu, Jul 27, 2023 at 05:38:04PM +0200, Joel Granados wrote: > On Wed, Jul 26, 2023 at 11:00:37AM -0700, Luis Chamberlain wrote: > > On Wed, Jul 26, 2023 at 04:06:29PM +0200, Joel Granados wrote: > > > This is part of the effort to remove the sentinel (last empty) element > > > from the ctl_table arrays. We update to the new function and pass it the > > > array size. > > > > The commit log does not explain why. It also does not explain if there > > is any delta on size at compile or runtime. > Just to be on the same page: > You mean the specific why for this commit. like for example: > " > We update to register_net_sysctl_sz I think it is clearer to just say: Move from register_net_sysctl() to register_net_sysctl_sz() > to prepare for when the ctl_table > array sentinels are removed. That is not as clear. I think you should just spell it out. We want to use the syctl ARRAY_SIZE() when possible, and subsequent patches ... now the register_net_sysctl() while register_net_sysctl_sz() and this user and so we must use register_net_sysctl_sz(). > " > > right? Luis