netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Feiyang Chen <chenfeiyang@loongson.cn>
Cc: andrew@lunn.ch, hkallweit1@gmail.com, peppe.cavallaro@st.com,
	alexandre.torgue@foss.st.com, joabreu@synopsys.com,
	chenhuacai@loongson.cn, dongbiao@loongson.cn,
	loongson-kernel@lists.loongnix.cn, netdev@vger.kernel.org,
	loongarch@lists.linux.dev, chris.chenfeiyang@gmail.com
Subject: Re: [PATCH v2 06/10] net: stmmac: Add Loongson HWIF entry
Date: Fri, 28 Jul 2023 10:24:06 +0100	[thread overview]
Message-ID: <ZMOJNtClcAlWwZpP@shell.armlinux.org.uk> (raw)
In-Reply-To: <7cae63ede2792cb2a7189f251b282aecbb0945b1.1690439335.git.chenfeiyang@loongson.cn>

On Thu, Jul 27, 2023 at 03:18:06PM +0800, Feiyang Chen wrote:
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index e8619853b6d6..829de274e75d 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -3505,17 +3505,21 @@ static int stmmac_request_irq_multi_msi(struct net_device *dev)
>  {
>  	struct stmmac_priv *priv = netdev_priv(dev);
>  	enum request_irq_err irq_err;
> +	unsigned long flags = 0;
>  	cpumask_t cpu_mask;
>  	int irq_idx = 0;
>  	char *int_name;
>  	int ret;
>  	int i;
>  
> +	if (priv->plat->has_lgmac)
> +		flags |= IRQF_TRIGGER_RISING;

Can this be described in firmware?

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

  parent reply	other threads:[~2023-07-28  9:24 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-27  7:15 [PATCH v2 00/10] stmmac: Add Loongson platform support Feiyang Chen
2023-07-27  7:15 ` [PATCH v2 01/10] net: stmmac: Pass stmmac_priv and chan in some callbacks Feiyang Chen
2023-07-27  7:15 ` [PATCH v2 03/10] net: stmmac: dwmac1000: Add multi-channel support Feiyang Chen
2023-07-27  9:01   ` Andrew Lunn
2023-07-28  1:51     ` Feiyang Chen
2023-07-27 10:31   ` kernel test robot
2023-07-27 16:35   ` kernel test robot
2023-07-27  7:15 ` [PATCH v2 04/10] net: stmmac: dwmac1000: Add 64-bit DMA support Feiyang Chen
2023-07-27  9:06   ` Andrew Lunn
2023-07-28  1:40     ` Feiyang Chen
2023-07-27  7:18 ` [PATCH v2 02/10] net: stmmac: dwmac1000: Allow platforms to choose some register offsets Feiyang Chen
2023-07-27  9:10   ` Andrew Lunn
2023-07-28  1:41     ` Feiyang Chen
2023-07-27  7:18 ` [PATCH v2 05/10] net: stmmac: dwmac1000: Add Loongson register definitions Feiyang Chen
2023-07-27  9:13   ` Andrew Lunn
2023-07-28  1:45     ` Feiyang Chen
2023-07-28  8:44       ` Andrew Lunn
2023-07-31  9:39         ` Feiyang Chen
2023-07-27  7:18 ` [PATCH v2 06/10] net: stmmac: Add Loongson HWIF entry Feiyang Chen
2023-07-28  6:36   ` Ravi Gunasekaran
2023-07-31  9:44     ` Feiyang Chen
2023-07-28  9:24   ` Russell King (Oracle) [this message]
2023-07-31  9:46     ` Feiyang Chen
2023-07-31 15:16       ` Russell King (Oracle)
2023-08-03  1:33         ` Feiyang Chen
2023-07-27  7:18 ` [PATCH v2 07/10] net: stmmac: dwmac-loongson: Add LS7A support Feiyang Chen
2023-07-27  9:18   ` Andrew Lunn
2023-07-28  1:59     ` Feiyang Chen
2023-07-28  8:46       ` Andrew Lunn
2023-07-31  9:42         ` Feiyang Chen
2023-07-27 10:35   ` Andrew Lunn
2023-07-28  2:00     ` Feiyang Chen
2023-07-27  7:18 ` [PATCH v2 08/10] net: stmmac: dwmac-loongson: Disable flow control for GMAC Feiyang Chen
2023-07-27 10:36   ` Andrew Lunn
2023-07-28  1:46     ` Feiyang Chen
2023-07-27  7:18 ` [PATCH v2 09/10] net: stmmac: dwmac-loongson: Add 64-bit DMA and multi-vector support Feiyang Chen
2023-07-27 10:37   ` Andrew Lunn
2023-07-28  1:47     ` Feiyang Chen
2023-07-27  7:18 ` [PATCH v2 10/10] net: stmmac: dwmac-loongson: Add GNET support Feiyang Chen
2023-07-27 10:43   ` Andrew Lunn
2023-07-28  1:47     ` Feiyang Chen
2023-07-27  9:02 ` [PATCH v2 00/10] stmmac: Add Loongson platform support Jose Abreu
2023-07-28  1:36   ` Feiyang Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZMOJNtClcAlWwZpP@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=alexandre.torgue@foss.st.com \
    --cc=andrew@lunn.ch \
    --cc=chenfeiyang@loongson.cn \
    --cc=chenhuacai@loongson.cn \
    --cc=chris.chenfeiyang@gmail.com \
    --cc=dongbiao@loongson.cn \
    --cc=hkallweit1@gmail.com \
    --cc=joabreu@synopsys.com \
    --cc=loongarch@lists.linux.dev \
    --cc=loongson-kernel@lists.loongnix.cn \
    --cc=netdev@vger.kernel.org \
    --cc=peppe.cavallaro@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).