* [PATCH net-next] net: bcmgenet: Remove TX ring full logging
@ 2023-07-28 18:39 Florian Fainelli
2023-07-31 7:33 ` Simon Horman
2023-07-31 21:50 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Florian Fainelli @ 2023-07-28 18:39 UTC (permalink / raw)
To: netdev
Cc: Florian Fainelli, Doug Berger,
Broadcom internal kernel review list, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, open list
[-- Attachment #1: Type: text/plain, Size: 966 bytes --]
There is no need to spam the kernel log with such an indication, remove
this message.
Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
---
drivers/net/ethernet/broadcom/genet/bcmgenet.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
index 2b5761ad2f92..24bade875ca6 100644
--- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
+++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
@@ -2077,12 +2077,8 @@ static netdev_tx_t bcmgenet_xmit(struct sk_buff *skb, struct net_device *dev)
spin_lock(&ring->lock);
if (ring->free_bds <= (nr_frags + 1)) {
- if (!netif_tx_queue_stopped(txq)) {
+ if (!netif_tx_queue_stopped(txq))
netif_tx_stop_queue(txq);
- netdev_err(dev,
- "%s: tx ring %d full when queue %d awake\n",
- __func__, index, ring->queue);
- }
ret = NETDEV_TX_BUSY;
goto out;
}
--
2.34.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: bcmgenet: Remove TX ring full logging
2023-07-28 18:39 [PATCH net-next] net: bcmgenet: Remove TX ring full logging Florian Fainelli
@ 2023-07-31 7:33 ` Simon Horman
2023-07-31 21:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2023-07-31 7:33 UTC (permalink / raw)
To: Florian Fainelli
Cc: netdev, Doug Berger, Broadcom internal kernel review list,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
open list
On Fri, Jul 28, 2023 at 11:39:45AM -0700, Florian Fainelli wrote:
> There is no need to spam the kernel log with such an indication, remove
> this message.
>
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: bcmgenet: Remove TX ring full logging
2023-07-28 18:39 [PATCH net-next] net: bcmgenet: Remove TX ring full logging Florian Fainelli
2023-07-31 7:33 ` Simon Horman
@ 2023-07-31 21:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-07-31 21:50 UTC (permalink / raw)
To: Florian Fainelli
Cc: netdev, opendmb, bcm-kernel-feedback-list, davem, edumazet, kuba,
pabeni, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 28 Jul 2023 11:39:45 -0700 you wrote:
> There is no need to spam the kernel log with such an indication, remove
> this message.
>
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
> ---
> drivers/net/ethernet/broadcom/genet/bcmgenet.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
Here is the summary with links:
- [net-next] net: bcmgenet: Remove TX ring full logging
https://git.kernel.org/netdev/net-next/c/df41fa677d9b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-31 21:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-28 18:39 [PATCH net-next] net: bcmgenet: Remove TX ring full logging Florian Fainelli
2023-07-31 7:33 ` Simon Horman
2023-07-31 21:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).