public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Richard Cochran <richardcochran@gmail.com>
To: Vishvambar Panth S <vishvambarpanth.s@microchip.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	bryan.whitehead@microchip.com, UNGLinuxDriver@microchip.com,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com
Subject: Re: [PATCH net-next] net: lan743x: skip timestamping for non-PTP packets
Date: Mon, 31 Jul 2023 06:51:10 -0700	[thread overview]
Message-ID: <ZMe8To+Rw0/pcjLv@hoboy.vegasvil.org> (raw)
In-Reply-To: <20230731125418.75140-1-vishvambarpanth.s@microchip.com>

On Mon, Jul 31, 2023 at 06:24:18PM +0530, Vishvambar Panth S wrote:
> Currently all the RX packets are timestamped and the timestamp is appended
> to the RX packet for processing, this reduces RX throughput. This can be
> optimized by timestamping packets only when the PTP messages are received.

No, you should not do this unconditionally.

Instead, you need to dial the correct setting based on the
hwtstamp_config in lan743x_ptp_ioctl().

Thanks,
Richard

  parent reply	other threads:[~2023-07-31 13:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-31 12:54 [PATCH net-next] net: lan743x: skip timestamping for non-PTP packets Vishvambar Panth S
2023-07-31 13:45 ` Vadim Fedorenko
2023-08-03  3:41   ` VishvambarPanth.S
2023-07-31 13:51 ` Richard Cochran [this message]
2023-08-03  3:39   ` VishvambarPanth.S

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZMe8To+Rw0/pcjLv@hoboy.vegasvil.org \
    --to=richardcochran@gmail.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=bryan.whitehead@microchip.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=vishvambarpanth.s@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox