From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 071492AB2C for ; Tue, 1 Aug 2023 12:31:55 +0000 (UTC) Received: from pandora.armlinux.org.uk (unknown [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1E051FC6; Tue, 1 Aug 2023 05:31:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=O5BpbWyfcEEuwF+JAY8ZIieV4+oN3raF7W0DkD+op+0=; b=Yf335vIUTDg0kFiXcYLf0LDUwV j2hLT+EGGETDCWjACzUUvktloFPJ0zsbciVjHsPIOjYlWuEvfLEouaUvvoQP+OQ0fVmyT5w4KGzq8 RM/H21+9gDq7/1VH53ZVJhe+uiBxT8Oh9XeKYDYo4/f79r63TgvouXZqvlxIJ0GqRW6WmHAUU1oUs 9k1Up5jOYud3NGwqUGTLpgc3mYs8UOqa7m6qi8QkmU0ZGNs/P37Q04papAO2qgDaC9tLPmOyTstxR 5SElIkb/nte+vuNQvPg+2nNIrV40SWEkR2GWideULbchY13MQUYfPLGQv/gtdyFPmDljv8TCwUvZD lXLZgClw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:41504) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qQoXR-00044N-1s; Tue, 01 Aug 2023 13:31:45 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qQoXR-0000gq-KG; Tue, 01 Aug 2023 13:31:45 +0100 Date: Tue, 1 Aug 2023 13:31:45 +0100 From: "Russell King (Oracle)" To: Matti Vaittinen Cc: Matti Vaittinen , Marcin Wojtas , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v8 8/8] net-next: mvpp2: don't shadow error Message-ID: References: <8c5b976a4ef9ba38fc952e9cf61848baa3e9dfe7.1690890774.git.mazziesaccount@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8c5b976a4ef9ba38fc952e9cf61848baa3e9dfe7.1690890774.git.mazziesaccount@gmail.com> Sender: Russell King (Oracle) X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,RDNS_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Tue, Aug 01, 2023 at 03:04:40PM +0300, Matti Vaittinen wrote: > Do not overwrite error from lower layers but return the actual error to > user if obtaining an IRQ fails. > > Suggested-by: Andy Shevchenko > Suggested-by: Jonathan Cameron > Signed-off-by: Matti Vaittinen Since your previous patch is incorrect, this one is too. NAK. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!