* [PATCH net-next] net: Remove duplicated include in mac.c
@ 2023-08-01 0:50 Yang Li
2023-08-01 10:06 ` Simon Horman
2023-08-02 10:50 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Yang Li @ 2023-08-01 0:50 UTC (permalink / raw)
To: madalin.bucur, davem, kuba, edumazet, sean.anderson, pabeni
Cc: netdev, linux-kernel, Yang Li, Abaci Robot
./drivers/net/ethernet/freescale/fman/mac.c: linux/of_platform.h is included more than once.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6039
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/net/ethernet/freescale/fman/mac.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fman/mac.c b/drivers/net/ethernet/freescale/fman/mac.c
index b6c7c4c0b367..9767586b4eb3 100644
--- a/drivers/net/ethernet/freescale/fman/mac.c
+++ b/drivers/net/ethernet/freescale/fman/mac.c
@@ -12,7 +12,6 @@
#include <linux/of_net.h>
#include <linux/of_mdio.h>
#include <linux/device.h>
-#include <linux/of_platform.h>
#include <linux/phy.h>
#include <linux/netdevice.h>
#include <linux/phy_fixed.h>
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: Remove duplicated include in mac.c
2023-08-01 0:50 [PATCH net-next] net: Remove duplicated include in mac.c Yang Li
@ 2023-08-01 10:06 ` Simon Horman
2023-08-02 10:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2023-08-01 10:06 UTC (permalink / raw)
To: Yang Li
Cc: madalin.bucur, davem, kuba, edumazet, sean.anderson, pabeni,
netdev, linux-kernel, Abaci Robot
On Tue, Aug 01, 2023 at 08:50:41AM +0800, Yang Li wrote:
> ./drivers/net/ethernet/freescale/fman/mac.c: linux/of_platform.h is included more than once.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6039
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Looking at git history, I think that a slightly better prefix would be
'net: fman: '.
Subject: [PATCH net-next] net: fman: ...
But other than that, this looks good to me.
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: Remove duplicated include in mac.c
2023-08-01 0:50 [PATCH net-next] net: Remove duplicated include in mac.c Yang Li
2023-08-01 10:06 ` Simon Horman
@ 2023-08-02 10:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-08-02 10:50 UTC (permalink / raw)
To: Yang Li
Cc: madalin.bucur, davem, kuba, edumazet, sean.anderson, pabeni,
netdev, linux-kernel, abaci
Hello:
This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:
On Tue, 1 Aug 2023 08:50:41 +0800 you wrote:
> ./drivers/net/ethernet/freescale/fman/mac.c: linux/of_platform.h is included more than once.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6039
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/net/ethernet/freescale/fman/mac.c | 1 -
> 1 file changed, 1 deletion(-)
Here is the summary with links:
- [net-next] net: Remove duplicated include in mac.c
https://git.kernel.org/netdev/net-next/c/34093c9fa05d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-02 10:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-01 0:50 [PATCH net-next] net: Remove duplicated include in mac.c Yang Li
2023-08-01 10:06 ` Simon Horman
2023-08-02 10:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).