From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1BF420F83 for ; Tue, 1 Aug 2023 17:27:07 +0000 (UTC) Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71062DB for ; Tue, 1 Aug 2023 10:27:04 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-99bcf2de59cso923050966b.0 for ; Tue, 01 Aug 2023 10:27:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20221208.gappssmtp.com; s=20221208; t=1690910823; x=1691515623; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zEQoCBAZE+MrFQ0nMFtOlsgCpzDjMhKc4sVhqgkx9HM=; b=SAGRQppniqtpk3rcPElEYgz1NyJdUcNTggSyjoc0wjKjaftLOjT3ugkqywXIIETU74 6BtJ7wrTbFM18bf+Ih3ZqtGJXzUTh+NCWcKLkqb7riKqO9wJFFp4rtHIFscwrh21nVPk VI//uuh4Roe2Q7ZNsz3pDzaVhsnZsOaumgPXhIoKTWXWwzxN1VMm1JLRmxGb8SC1rdHY lTNVhRQMXVdGbZJJnuliITa6FvOWoY/DjLZqI2CWp8OM0ckByB16AVQ87sjeGlV2h9de ph+v5rind7isXpqv63AY/5C9xrxFm3drQ6VIZ2ZA1W2+FOb/MJwrEca1YX/EnMBGlCS7 fVvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690910823; x=1691515623; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zEQoCBAZE+MrFQ0nMFtOlsgCpzDjMhKc4sVhqgkx9HM=; b=WEfrVh+Zk61TodCK+PFpmZpp/G0yr7oBcwIQAt/G67NGDSF1+EEJcTLuSwGTmRB19C Djdh8q+oHzn8WHAw3kDgl+QwnyujRcqRvcl4xPWuphfWWiyiJmUQUeKJWSE/vtNoMvn2 5dSkTMi/f9zj95a3psGQwHqw6NHkv8gOtLndTyubsjjUQ+2wtYYbfIF02eQLu03fFpS5 nOMKFud7r0LuU5L7lZHfdU66cN+fLRspSFf25tNdZv40NLnfFIqMEtKTkm3buZc+sKNJ GMIfPJJ+3hW9pYC1f5cRoz3dHYeMCuMcHXNRnDfLtX6V+r8dJqtowg1H+DzpxJaT4VyS /R6w== X-Gm-Message-State: ABy/qLa/AJIk5k2ic452izLUXck13ffYgtTTNr1Vu+DxdqRO0+UcxtWL j4JgoHl6vEW9Bzi7khbgTg4l7g== X-Google-Smtp-Source: APBJJlEYA4oxxOGVRYBjWgY0YEmsYh+uGbqMnSpHCYWTwyPci+Bj1hZ6C2f4wy1loM47PlodnHEOHA== X-Received: by 2002:a17:906:53cd:b0:99b:c2d4:ddd8 with SMTP id p13-20020a17090653cd00b0099bc2d4ddd8mr3250035ejo.31.1690910822788; Tue, 01 Aug 2023 10:27:02 -0700 (PDT) Received: from localhost ([212.23.236.67]) by smtp.gmail.com with ESMTPSA id i10-20020a170906250a00b009931baa0d44sm8029171ejb.140.2023.08.01.10.27.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Aug 2023 10:27:02 -0700 (PDT) Date: Tue, 1 Aug 2023 19:27:01 +0200 From: Jiri Pirko To: Anvesh Jain P Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Kuniyuki Iwashima , Hangbin Liu , Heiner Kallweit , Andy Ren , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Venkata Rao Kakani , Vagdhan Kumar Subject: Re: [PATCH] net: export dev_change_name function Message-ID: References: <20230801112101.15564-1-quic_ajainp@quicinc.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230801112101.15564-1-quic_ajainp@quicinc.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Tue, Aug 01, 2023 at 01:21:01PM CEST, quic_ajainp@quicinc.com wrote: >export dev_change_name function to be used by other modules. > >Signed-off-by: Vagdhan Kumar >Signed-off-by: Anvesh Jain P >--- > net/core/dev.c | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/net/core/dev.c b/net/core/dev.c >index 69a3e544676c..1dad68e2950c 100644 >--- a/net/core/dev.c >+++ b/net/core/dev.c >@@ -1254,6 +1254,7 @@ int dev_change_name(struct net_device *dev, const char *newname) > > return err; > } >+EXPORT_SYMBOL(dev_change_name); > > /** > * dev_set_alias - change ifalias of a device > >base-commit: 0a8db05b571ad5b8d5c8774a004c0424260a90bd nack. 1) there is no in-tree user 2) changing name from anywhere else than userspace does not make any sense. I'll eat my shoes if there is a sane reason for it. Please don't send patches like this. >-- >2.17.1 >