[PATCH net-next] tipc: Remove unused function declarations

[PATCH net-next] tipc: Remove unused function declarations

[Yue Haibing]

Commit d50ccc2d3909 ("tipc: add 128-bit node identifier") declared but never
implemented tipc_node_id2hash().
Also commit 5c216e1d28c8 ("tipc: Allow run-time alteration of default link settings")
never implemented tipc_media_set_priority() and tipc_media_set_window(),
commit cad2929dc432 ("tipc: update a binding service via broadcast") only declared
tipc_named_bcast().

Since commit be07f056396d ("tipc: simplify the finalize work queue")
tipc_sched_net_finalize() is removed and declaration is unused.

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
 net/tipc/addr.h       | 1 -
 net/tipc/bearer.h     | 2 --
 net/tipc/name_distr.h | 1 -
 net/tipc/net.h        | 1 -
 4 files changed, 5 deletions(-)

diff --git a/net/tipc/addr.h b/net/tipc/addr.h
index 0772cfadaa0d..93f82398283d 100644
--- a/net/tipc/addr.h
+++ b/net/tipc/addr.h
@@ -131,6 +131,5 @@ bool tipc_in_scope(bool legacy_format, u32 domain, u32 addr);
 void tipc_set_node_id(struct net *net, u8 *id);
 void tipc_set_node_addr(struct net *net, u32 addr);
 char *tipc_nodeid2string(char *str, u8 *id);
-u32 tipc_node_id2hash(u8 *id128);
 
 #endif
diff --git a/net/tipc/bearer.h b/net/tipc/bearer.h
index 1ee60649bd17..41eac1ee0c09 100644
--- a/net/tipc/bearer.h
+++ b/net/tipc/bearer.h
@@ -214,8 +214,6 @@ int tipc_nl_media_get(struct sk_buff *skb, struct genl_info *info);
 int tipc_nl_media_set(struct sk_buff *skb, struct genl_info *info);
 int __tipc_nl_media_set(struct sk_buff *skb, struct genl_info *info);
 
-int tipc_media_set_priority(const char *name, u32 new_value);
-int tipc_media_set_window(const char *name, u32 new_value);
 int tipc_media_addr_printf(char *buf, int len, struct tipc_media_addr *a);
 int tipc_enable_l2_media(struct net *net, struct tipc_bearer *b,
 			 struct nlattr *attrs[]);
diff --git a/net/tipc/name_distr.h b/net/tipc/name_distr.h
index e231e6964d61..c677f6f082df 100644
--- a/net/tipc/name_distr.h
+++ b/net/tipc/name_distr.h
@@ -67,7 +67,6 @@ struct distr_item {
 	__be32 key;
 };
 
-void tipc_named_bcast(struct net *net, struct sk_buff *skb);
 struct sk_buff *tipc_named_publish(struct net *net, struct publication *publ);
 struct sk_buff *tipc_named_withdraw(struct net *net, struct publication *publ);
 void tipc_named_node_up(struct net *net, u32 dnode, u16 capabilities);
diff --git a/net/tipc/net.h b/net/tipc/net.h
index d0c91d2df20a..1cb1e43cf34a 100644
--- a/net/tipc/net.h
+++ b/net/tipc/net.h
@@ -43,7 +43,6 @@ extern const struct nla_policy tipc_nl_net_policy[];
 
 int tipc_net_init(struct net *net, u8 *node_id, u32 addr);
 void tipc_net_finalize_work(struct work_struct *work);
-void tipc_sched_net_finalize(struct net *net, u32 addr);
 void tipc_net_stop(struct net *net);
 int tipc_nl_net_dump(struct sk_buff *skb, struct netlink_callback *cb);
 int tipc_nl_net_set(struct sk_buff *skb, struct genl_info *info);
-- 
2.34.1

Re: [PATCH net-next] tipc: Remove unused function declarations

[Simon Horman]

On Wed, Aug 02, 2023 at 11:46:59AM +0800, Yue Haibing wrote:
> Commit d50ccc2d3909 ("tipc: add 128-bit node identifier") declared but never
> implemented tipc_node_id2hash().
> Also commit 5c216e1d28c8 ("tipc: Allow run-time alteration of default link settings")
> never implemented tipc_media_set_priority() and tipc_media_set_window(),
> commit cad2929dc432 ("tipc: update a binding service via broadcast") only declared
> tipc_named_bcast().
> 
> Since commit be07f056396d ("tipc: simplify the finalize work queue")
> tipc_sched_net_finalize() is removed and declaration is unused.
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH net-next] tipc: Remove unused function declarations

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Wed, 2 Aug 2023 11:46:59 +0800 you wrote:
> Commit d50ccc2d3909 ("tipc: add 128-bit node identifier") declared but never
> implemented tipc_node_id2hash().
> Also commit 5c216e1d28c8 ("tipc: Allow run-time alteration of default link settings")
> never implemented tipc_media_set_priority() and tipc_media_set_window(),
> commit cad2929dc432 ("tipc: update a binding service via broadcast") only declared
> tipc_named_bcast().
> 
> [...]

Here is the summary with links:
  - [net-next] tipc: Remove unused function declarations
    https://git.kernel.org/netdev/net-next/c/c956910d5af1

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html