From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1E0FDF42 for ; Wed, 2 Aug 2023 17:11:10 +0000 (UTC) Received: from pandora.armlinux.org.uk (unknown [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1518C3ABF; Wed, 2 Aug 2023 10:10:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=XLLd9JRsTfglVaTMLYzB9zf25h2aUdYg0+uTzR/qre8=; b=yfcuwZbdJMlhz2J+55Mk+VvmXb w5WOVj0tW8C6M/dSp00jvyPjXLjeZ6+118E+OmADowz6/MJoOFHi4pXq4lb4EpZ0FcyDCJecJjCfk L24idD7TcElCn1WaqkHfG31lbOFTnu5zFnuVK3ILXYHIRZggsRrcOxlp/AShet7cB6IEinAeWIgrF u3xx3Qt6WYzNjUK8N5UPjuS0S/09f0YPMHIfLv2/QvFlGyw1z7F1+YcLPMlYCkXwnfU5yffsglwVw JpqKVnlW4dN1LaCb7UVC7DW4naMW+pq07lNXd/cokyiJp+jsv9mmo2n91pNfeRujCMRPLeowzeygq zfZ9DLVg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:57834) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qRFMk-0005iW-1K; Wed, 02 Aug 2023 18:10:31 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qRFMh-00023v-Q5; Wed, 02 Aug 2023 18:10:27 +0100 Date: Wed, 2 Aug 2023 18:10:27 +0100 From: "Russell King (Oracle)" To: Andrew Lunn Cc: Michael Walle , Heiner Kallweit , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Yisen Zhuang , Salil Mehta , Florian Fainelli , Broadcom internal kernel review list , Marek =?iso-8859-1?Q?Beh=FAn?= , Xu Liang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Simon Horman Subject: Re: [PATCH net-next v3 02/11] net: phy: introduce phy_has_c45_registers() Message-ID: References: <20230620-feature-c45-over-c22-v3-0-9eb37edf7be0@kernel.org> <20230620-feature-c45-over-c22-v3-2-9eb37edf7be0@kernel.org> <7be8b305-f287-4e99-bddd-55646285c427@lunn.ch> <867ae3cc05439599d63e4712bca79e27@kernel.org> <7c29bfa7-b4a6-49c9-9369-d98bae98f135@lunn.ch> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7c29bfa7-b4a6-49c9-9369-d98bae98f135@lunn.ch> Sender: Russell King (Oracle) X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,RDNS_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Wed, Aug 02, 2023 at 06:15:19PM +0200, Andrew Lunn wrote: > > I'm confused now. Andrew suggested to split it into four different > > functions: > > > > phy_has_c22_registers() > > phy_has_c45_registers() > > phy_has_c22_transfers() > > phy_has_c45_transfers() > > > > Without a functional change. That is, either return phydev->is_c45 > > or the inverse. > > Without a functional change at this step of introducing the four > functions. Then later really implement them to do what the name > implies. Doing it in steps helps with bisect when it breaks something. > > It could also be that not all four are needed, or not all four are > possible. But the four express the full combinations of transfers and > registers. I'm left wondering how you think that phy_has_c45_registers() can be implemented in a useful way, because I'm at a total loss... -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!