From: Jiri Pirko <jiri@resnulli.us>
To: Jinjian Song <songjinjian@hotmail.com>
Cc: netdev@vger.kernel.org, kuba@kernel.org, davem@davemloft.net,
johannes@sipsolutions.net, ryazanov.s.a@gmail.com,
loic.poulain@linaro.org, ilpo.jarvinen@linux.intel.com,
ricardo.martinez@linux.intel.com,
chiranjeevi.rapolu@linux.intel.com, haijun.liu@mediatek.com,
edumazet@google.com, pabeni@redhat.com,
chandrashekar.devegowda@intel.com,
m.chetan.kumar@linux.intel.com, linuxwwan@intel.com,
linuxwwan_5g@intel.com, soumya.prakash.mishra@intel.com,
jesse.brandeburg@intel.com, danielwinkler@google.com,
Jinjian Song <jinjian.song@fibocom.com>
Subject: Re: [net-next 2/6] net: wwan: t7xx: Driver registers with Devlink framework
Date: Thu, 3 Aug 2023 11:59:01 +0200 [thread overview]
Message-ID: <ZMt6ZZxIHMrml0+E@nanopsycho> (raw)
In-Reply-To: <MEYP282MB269720DC5940AEA0904569B3BB08A@MEYP282MB2697.AUSP282.PROD.OUTLOOK.COM>
Thu, Aug 03, 2023 at 04:18:08AM CEST, songjinjian@hotmail.com wrote:
[...]
>+static const struct devlink_param t7xx_devlink_params[] = {
>+ DEVLINK_PARAM_DRIVER(T7XX_DEVLINK_PARAM_ID_FASTBOOT,
>+ "fastboot", DEVLINK_PARAM_TYPE_BOOL,
>+ BIT(DEVLINK_PARAM_CMODE_DRIVERINIT),
>+ NULL, NULL, NULL),
driver init params is there so the user could configure driver instance
and then hit devlink reload in order to reinitialize with the new param
values. In your case, it is a device command. Does not make any sense to
have it as param.
NAK
next prev parent reply other threads:[~2023-08-03 9:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230803021812.6126-1-songjinjian@hotmail.com>
2023-08-03 2:18 ` [net-next 1/6] net: wwan: t7xx: Infrastructure for early port configuration Jinjian Song
2023-08-03 2:18 ` [net-next 2/6] net: wwan: t7xx: Driver registers with Devlink framework Jinjian Song
2023-08-03 9:31 ` Jiri Pirko
2023-08-03 9:59 ` Jiri Pirko [this message]
2023-08-05 10:25 ` Jinjian Song
2023-08-05 12:12 ` Jinjian Song
2023-08-07 7:22 ` Jiri Pirko
2023-08-07 12:44 ` Jinjian Song
2023-08-07 12:58 ` Jiri Pirko
2023-08-10 15:19 ` Jinjian Song
2023-08-03 2:18 ` [net-next 3/6] net: wwan: t7xx: Implements devlink ops of firmware flashing Jinjian Song
2023-08-03 9:52 ` Jiri Pirko
2023-08-05 12:05 ` Jinjian Song
2023-08-07 7:35 ` Jiri Pirko
2023-08-07 12:26 ` Jinjian Song
2023-08-07 13:01 ` Jiri Pirko
2023-08-10 15:32 ` Jinjian Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMt6ZZxIHMrml0+E@nanopsycho \
--to=jiri@resnulli.us \
--cc=chandrashekar.devegowda@intel.com \
--cc=chiranjeevi.rapolu@linux.intel.com \
--cc=danielwinkler@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=haijun.liu@mediatek.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=jinjian.song@fibocom.com \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linuxwwan@intel.com \
--cc=linuxwwan_5g@intel.com \
--cc=loic.poulain@linaro.org \
--cc=m.chetan.kumar@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ricardo.martinez@linux.intel.com \
--cc=ryazanov.s.a@gmail.com \
--cc=songjinjian@hotmail.com \
--cc=soumya.prakash.mishra@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox