From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, pabeni@redhat.com, davem@davemloft.net,
edumazet@google.com, moshe@nvidia.com, saeedm@nvidia.com,
idosch@nvidia.com, petrm@nvidia.com
Subject: Re: [patch net-next v2 00/11] devlink: use spec to generate split ops
Date: Thu, 3 Aug 2023 08:01:34 +0200 [thread overview]
Message-ID: <ZMtCvitU6o2e41up@nanopsycho> (raw)
In-Reply-To: <20230802190734.4a9f9c0a@kernel.org>
Thu, Aug 03, 2023 at 04:07:34AM CEST, kuba@kernel.org wrote:
>On Wed, 2 Aug 2023 17:20:12 +0200 Jiri Pirko wrote:
>> This is an outcome of the discussion in the following thread:
>> https://lore.kernel.org/netdev/20230720121829.566974-1-jiri@resnulli.us/
>> It serves as a dependency on the linked selector patchset.
>>
>> There is an existing spec for devlink used for userspace part
>> generation. There are two commands supported there.
>>
>> This patchset extends the spec so kernel split ops code could
>> be generated from it.
>
>Looks good! But you need to reshuffle stuff in patches 7-10
>because there's a temporary build breakage. Some squashing,
>reordering and maybe splitting patch 10 should do?
I was very careful not to cause any breakage. Will double check, fix the
2 nits and send v3.
Thanks!
>
>Feel free to post v3 without waiting the full 24h.
>--
>pw-bot: cr
prev parent reply other threads:[~2023-08-03 6:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 15:20 [patch net-next v2 00/11] devlink: use spec to generate split ops Jiri Pirko
2023-08-02 15:20 ` [patch net-next v2 01/11] netlink: specs: add dump-strict flag for dont-validate property Jiri Pirko
2023-08-02 15:20 ` [patch net-next v2 02/11] ynl-gen-c.py: filter rendering of validate field values for split ops Jiri Pirko
2023-08-02 15:20 ` [patch net-next v2 03/11] ynl-gen-c.py: allow directional model for kernel mode Jiri Pirko
2023-08-03 1:54 ` Jakub Kicinski
2023-08-02 15:20 ` [patch net-next v2 04/11] ynl-gen-c.py: render netlink policies static for split ops Jiri Pirko
2023-08-02 15:20 ` [patch net-next v2 05/11] devlink: rename devlink_nl_ops to devlink_nl_small_ops Jiri Pirko
2023-08-02 15:20 ` [patch net-next v2 06/11] netlink: specs: devlink: add info-get dump op Jiri Pirko
2023-08-02 15:20 ` [patch net-next v2 07/11] devlink: add split ops generated according to spec Jiri Pirko
2023-08-02 15:20 ` [patch net-next v2 08/11] devlink: include the generated netlink header Jiri Pirko
2023-08-02 15:20 ` [patch net-next v2 09/11] devlink: rename couple of doit netlink callbacks to match generated names Jiri Pirko
2023-08-02 15:20 ` [patch net-next v2 10/11] devlink: introduce couple of dumpit callbacks for split ops Jiri Pirko
2023-08-03 2:04 ` Jakub Kicinski
2023-08-02 15:20 ` [patch net-next v2 11/11] devlink: use generated split ops and remove duplicated commands from small ops Jiri Pirko
2023-08-03 2:07 ` [patch net-next v2 00/11] devlink: use spec to generate split ops Jakub Kicinski
2023-08-03 6:01 ` Jiri Pirko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMtCvitU6o2e41up@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).