From: Jiri Pirko <jiri@resnulli.us>
To: Jinjian Song <songjinjian@hotmail.com>
Cc: netdev@vger.kernel.org, kuba@kernel.org, davem@davemloft.net,
johannes@sipsolutions.net, ryazanov.s.a@gmail.com,
loic.poulain@linaro.org, ilpo.jarvinen@linux.intel.com,
ricardo.martinez@linux.intel.com,
chiranjeevi.rapolu@linux.intel.com, haijun.liu@mediatek.com,
edumazet@google.com, pabeni@redhat.com,
chandrashekar.devegowda@intel.com,
m.chetan.kumar@linux.intel.com, linuxwwan@intel.com,
linuxwwan_5g@intel.com, soumya.prakash.mishra@intel.com,
jesse.brandeburg@intel.com, danielwinkler@google.com,
Jinjian Song <jinjian.song@fibocom.com>
Subject: Re: [net-next 0/6] net: wwan: t7xx: fw flashing & coredump support
Date: Thu, 3 Aug 2023 11:24:39 +0200 [thread overview]
Message-ID: <ZMtyV8qxr4RePrgb@nanopsycho> (raw)
In-Reply-To: <MEYP282MB26974DA32942DE35F636FA41BB08A@MEYP282MB2697.AUSP282.PROD.OUTLOOK.COM>
Thu, Aug 03, 2023 at 04:18:06AM CEST, songjinjian@hotmail.com wrote:
>From: Jinjian Song <jinjian.song@fibocom.com>
>
>Adds support for t7xx wwan device firmware flashing & coredump collection
>using devlink.
>
>On early detection of wwan device in fastboot mode driver sets up CLDMA0 HW
>tx/rx queues for raw data transfer and then registers to devlink framework.
>On user space application issuing command for firmware update the driver
>sends fastboot flash command & firmware to program NAND.
>
>In flashing procedure the fastboot command & response are exchanged between
>driver and device. Once firmware flashing is success, user space application
>get modem event by sysfs interface.
>
>Below is the devlink command usage for firmware flashing
>
>$devlink dev flash pci/$BDF file ABC.img component ABC
>
>Note: ABC.img is the firmware to be programmed to "ABC" partition.
>
>In case of coredump collection when wwan device encounters an exception
>it reboots & stays in fastboot mode for coredump collection by host driver.
>On detecting exception state driver collects the core dump, creates the
>devlink region & reports an event to user space application for dump
>collection. The user space application invokes devlink region read command
>for dump collection.
>
>Below are the devlink commands used for coredump collection.
>
>devlink region new pci/$BDF/mr_dump
>devlink region read pci/$BDF/mr_dump snapshot $ID address $ADD length $LEN
>devlink region del pci/$BDF/mr_dump snapshot $ID
Interesting. Makes me wonder why you didn't mention the "fastboot" param
in the cover letter...
>
>Jinjian Song (6):
> net: wwan: t7xx: Infrastructure for early port configuration
> net: wwan: t7xx: Driver registers with Devlink framework
> net: wwan: t7xx: Implements devlink ops of firmware flashing
> net: wwan: t7xx: Creates region & snapshot for coredump log collection
> net: wwan: t7xx: Adds sysfs attribute of modem event
> net: wwan: t7xx: Devlink documentation
>
> Documentation/networking/devlink/index.rst | 1 +
> Documentation/networking/devlink/t7xx.rst | 232 +++++++
> drivers/net/wwan/Kconfig | 1 +
> drivers/net/wwan/t7xx/Makefile | 4 +-
> drivers/net/wwan/t7xx/t7xx_hif_cldma.c | 47 +-
> drivers/net/wwan/t7xx/t7xx_hif_cldma.h | 18 +-
> drivers/net/wwan/t7xx/t7xx_modem_ops.c | 5 +-
> drivers/net/wwan/t7xx/t7xx_pci.c | 79 ++-
> drivers/net/wwan/t7xx/t7xx_pci.h | 19 +
> drivers/net/wwan/t7xx/t7xx_port.h | 6 +
> drivers/net/wwan/t7xx/t7xx_port_ap_msg.c | 78 +++
> drivers/net/wwan/t7xx/t7xx_port_ap_msg.h | 11 +
> drivers/net/wwan/t7xx/t7xx_port_devlink.c | 723 +++++++++++++++++++++
> drivers/net/wwan/t7xx/t7xx_port_devlink.h | 85 +++
> drivers/net/wwan/t7xx/t7xx_port_proxy.c | 118 +++-
> drivers/net/wwan/t7xx/t7xx_port_proxy.h | 14 +
> drivers/net/wwan/t7xx/t7xx_port_wwan.c | 27 +-
> drivers/net/wwan/t7xx/t7xx_reg.h | 28 +-
> drivers/net/wwan/t7xx/t7xx_state_monitor.c | 137 +++-
> drivers/net/wwan/t7xx/t7xx_state_monitor.h | 1 +
> 20 files changed, 1556 insertions(+), 78 deletions(-)
> create mode 100644 Documentation/networking/devlink/t7xx.rst
> create mode 100644 drivers/net/wwan/t7xx/t7xx_port_ap_msg.c
> create mode 100644 drivers/net/wwan/t7xx/t7xx_port_ap_msg.h
> create mode 100644 drivers/net/wwan/t7xx/t7xx_port_devlink.c
> create mode 100644 drivers/net/wwan/t7xx/t7xx_port_devlink.h
>
>--
>2.34.1
>
>
next prev parent reply other threads:[~2023-08-03 9:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 2:18 [net-next 0/6] net: wwan: t7xx: fw flashing & coredump support Jinjian Song
2023-08-03 9:24 ` Jiri Pirko [this message]
2023-08-05 9:07 ` Jinjian Song
-- strict thread matches above, loose matches on Subject: below --
2023-08-03 2:57 Jinjian Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMtyV8qxr4RePrgb@nanopsycho \
--to=jiri@resnulli.us \
--cc=chandrashekar.devegowda@intel.com \
--cc=chiranjeevi.rapolu@linux.intel.com \
--cc=danielwinkler@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=haijun.liu@mediatek.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=jinjian.song@fibocom.com \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linuxwwan@intel.com \
--cc=linuxwwan_5g@intel.com \
--cc=loic.poulain@linaro.org \
--cc=m.chetan.kumar@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ricardo.martinez@linux.intel.com \
--cc=ryazanov.s.a@gmail.com \
--cc=songjinjian@hotmail.com \
--cc=soumya.prakash.mishra@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox