From: Simon Horman <horms@kernel.org>
To: Rushil Gupta <rushilg@google.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
willemb@google.com, edumazet@google.com, pabeni@redhat.com,
Praveen Kaligineedi <pkaligineedi@google.com>,
Bailey Forrest <bcf@google.com>
Subject: Re: [PATCH net-next 1/4] gve: Control path for DQO-QPL
Date: Thu, 3 Aug 2023 11:28:33 +0200 [thread overview]
Message-ID: <ZMtzQfUsdf8iJL6F@kernel.org> (raw)
In-Reply-To: <20230802213338.2391025-2-rushilg@google.com>
On Wed, Aug 02, 2023 at 09:33:35PM +0000, Rushil Gupta wrote:
...
Hi Rashil,
> @@ -505,12 +524,24 @@ static int gve_adminq_create_tx_queue(struct gve_priv *priv, u32 queue_index)
>
> cmd.create_tx_queue.queue_page_list_id = cpu_to_be32(qpl_id);
> } else {
> + u16 comp_ring_size = 0;
> + u32 qpl_id = 0;
> +
> + if (priv->queue_format == GVE_DQO_RDA_FORMAT) {
> + qpl_id = GVE_RAW_ADDRESSING_QPL_ID;
> + comp_ring_size =
> + priv->options_dqo_rda.tx_comp_ring_entries;
> + } else {
> + qpl_id = tx->dqo.qpl->id;
The qpl field does not appear to be added to struct gve_tx_ring
until a following patch.
> + comp_ring_size = priv->tx_desc_cnt;
> + }
> + cmd.create_tx_queue.queue_page_list_id = cpu_to_be32(qpl_id);
> cmd.create_tx_queue.tx_ring_size =
> cpu_to_be16(priv->tx_desc_cnt);
> cmd.create_tx_queue.tx_comp_ring_addr =
> cpu_to_be64(tx->complq_bus_dqo);
> cmd.create_tx_queue.tx_comp_ring_size =
> - cpu_to_be16(priv->options_dqo_rda.tx_comp_ring_entries);
> + cpu_to_be16(comp_ring_size);
> }
>
> return gve_adminq_issue_cmd(priv, &cmd);
> @@ -555,6 +586,18 @@ static int gve_adminq_create_rx_queue(struct gve_priv *priv, u32 queue_index)
> cmd.create_rx_queue.queue_page_list_id = cpu_to_be32(qpl_id);
> cmd.create_rx_queue.packet_buffer_size = cpu_to_be16(rx->packet_buffer_size);
> } else {
> + u16 rx_buff_ring_entries = 0;
> + u32 qpl_id = 0;
> +
> + if (priv->queue_format == GVE_DQO_RDA_FORMAT) {
> + qpl_id = GVE_RAW_ADDRESSING_QPL_ID;
> + rx_buff_ring_entries =
> + priv->options_dqo_rda.rx_buff_ring_entries;
> + } else {
> + qpl_id = rx->dqo.qpl->id;
Likewise, the qpl field does not appear to be added to struct gve_rx_ring
until a following patch.
> + rx_buff_ring_entries = priv->rx_desc_cnt;
> + }
> + cmd.create_rx_queue.queue_page_list_id = cpu_to_be32(qpl_id);
> cmd.create_rx_queue.rx_ring_size =
> cpu_to_be16(priv->rx_desc_cnt);
> cmd.create_rx_queue.rx_desc_ring_addr =
...
--
pw-bot: changes-requested
next prev parent reply other threads:[~2023-08-03 9:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 21:33 [PATCH net-next 0/4] Add QPL mode for DQO descriptor format Rushil Gupta
2023-08-02 21:33 ` [PATCH net-next 1/4] gve: Control path for DQO-QPL Rushil Gupta
2023-08-03 1:56 ` Jesse Brandeburg
2023-08-03 19:18 ` Rushil Gupta
2023-08-03 9:28 ` Simon Horman [this message]
2023-08-02 21:33 ` [PATCH net-next 2/4] gve: Tx " Rushil Gupta
2023-08-02 21:33 ` [PATCH net-next 3/4] gve: RX " Rushil Gupta
2023-08-02 21:33 ` [PATCH net-next 4/4] gve: update gve.rst Rushil Gupta
-- strict thread matches above, loose matches on Subject: below --
2023-08-01 21:54 [PATCH net-next 0/4] Add QPL mode for DQO descriptor format Rushil Gupta
2023-08-01 21:54 ` [PATCH net-next 1/4] gve: Control path for DQO-QPL Rushil Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMtzQfUsdf8iJL6F@kernel.org \
--to=horms@kernel.org \
--cc=bcf@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pkaligineedi@google.com \
--cc=rushilg@google.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).