From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90E6C1F16D
	for <netdev@vger.kernel.org>; Thu,  3 Aug 2023 17:45:37 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F080C433C8;
	Thu,  3 Aug 2023 17:45:34 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1691084737;
	bh=NYvjsiwLCUT+hyfVYpuPUB20GDyJSX72vAXBvPGj2PA=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=aQauctMikTrBSs0A223sKVV9gnlWChPOmPXl4We56DDOlaag0jx6V7fYL32u2XCgD
	 Ao3c62a3ydN1UYQtyQhpAVqHmC5cIhncBzEOtQwEb10O4fC70+xMUcA3bn8lIFtQeA
	 2axsTcuHdFMEfiMBA6PHVLN5xMC0542jQVK/VPus5MBSy1QpKTKttN/szSrc3Omlch
	 +q0w4Yl86J5SdCwCGK2oiV1UyiAz6WoHeACGCD9qUlmEsLUY6uaYCoiwN5DRye87UR
	 f4Y5zpoQ6EFIzeD4fVUex6wcnSXpuqpHRRKoLPTC3om1DxlbLn8CNxJ2c115AyXXH9
	 pK6EMIbUKqEFg==
Date: Thu, 3 Aug 2023 19:45:32 +0200
From: Simon Horman <horms@kernel.org>
To: Guangguan Wang <guangguan.wang@linux.alibaba.com>
Cc: wenjia@linux.ibm.com, jaka@linux.ibm.com, kgraul@linux.ibm.com,
	tonylu@linux.alibaba.com, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, alibuda@linux.alibaba.com,
	guwen@linux.alibaba.com, linux-s390@vger.kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH net-next 2/6] net/smc: add vendor unique experimental
 options area in clc handshake
Message-ID: <ZMvnvLOZgtmS2IqN@kernel.org>
References: <20230803132422.6280-1-guangguan.wang@linux.alibaba.com>
 <20230803132422.6280-3-guangguan.wang@linux.alibaba.com>
Precedence: bulk
X-Mailing-List: netdev@vger.kernel.org
List-Id: <netdev.vger.kernel.org>
List-Subscribe: <mailto:netdev+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:netdev+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230803132422.6280-3-guangguan.wang@linux.alibaba.com>

On Thu, Aug 03, 2023 at 09:24:18PM +0800, Guangguan Wang wrote:

...

Hi Guangguan Wang,

> @@ -987,12 +991,12 @@ static int smc_clc_send_confirm_accept(struct smc_sock *smc,
>  {
>  	struct smc_connection *conn = &smc->conn;
>  	struct smc_clc_msg_accept_confirm *clc;
> -	struct smc_clc_first_contact_ext fce;
> +	struct smc_clc_first_contact_ext_v2x fce;
>  	struct smc_clc_fce_gid_ext gle;
>  	struct smc_clc_msg_trail trl;
>  	struct kvec vec[5];
>  	struct msghdr msg;
> -	int i, len;
> +	int i, len, fce_len;

Please preserve reverse xmas tree - longest line to shortest -
for local variable declarations: this is Networking code.

https://github.com/ecree-solarflare/xmastree is your friend here.

...