netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@idosch.org>
To: Gal Pressman <gal@nvidia.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
	kuba@kernel.org, ast@kernel.org, bpf@vger.kernel.org,
	netdev@vger.kernel.org,
	syzbot+bdcf141f362ef83335cf@syzkaller.appspotmail.com,
	syzbot+b202b7208664142954fa@syzkaller.appspotmail.com,
	syzbot+14736e249bce46091c18@syzkaller.appspotmail.com
Subject: Re: [PATCH net-next] tcx: Fix splat in ingress_destroy upon tcx_entry_free
Date: Fri, 4 Aug 2023 16:31:39 +0300	[thread overview]
Message-ID: <ZMz9u+yZtk8vf+OP@shredder> (raw)
In-Reply-To: <bdfc2640-8f65-5b56-4472-db8e2b161aab@nvidia.com>

On Thu, Aug 03, 2023 at 02:10:51PM +0300, Gal Pressman wrote:
> Our nightly regression testing picked up new memory leaks which were
> bisected to this commit.
> Unfortunately, I do not know the exact repro steps to trigger it, maybe
> the attached kmemeleak logs can help?

[...]

> unreferenced object 0xffff88812acdebc0 (size 16):
>   comm "umount.nfs", pid 11626, jiffies 4295354796 (age 45.472s)
>   hex dump (first 16 bytes):
>     73 65 72 76 65 72 2d 32 00 eb cd 2a 81 88 ff ff  server-2...*....
>   backtrace:
>     [<0000000010fb5130>] __kmalloc_node_track_caller+0x4c/0x170
>     [<00000000b866a733>] kvasprintf+0xb0/0x130
>     [<00000000b3564fca>] kasprintf+0xa6/0xd0
>     [<00000000f01d6cb3>] nfs_sysfs_move_sb_to_server+0x49/0xd0
>     [<000000009608708f>] nfs_kill_super+0x5f/0x90
>     [<0000000090d4108b>] deactivate_locked_super+0x80/0x130
>     [<000000000856aeb1>] cleanup_mnt+0x258/0x370
>     [<0000000040582e39>] task_work_run+0x12c/0x210
>     [<00000000378ea041>] exit_to_user_mode_prepare+0x1a0/0x1b0
>     [<00000000025e63dd>] syscall_exit_to_user_mode+0x19/0x50
>     [<00000000f34ad3ee>] do_syscall_64+0x4a/0x90
>     [<000000009d3e2403>] entry_SYSCALL_64_after_hwframe+0x46/0xb0

This one is caused by commit 1c7251187dc0 ("NFS: add superblock sysfs
entries") and fixed by [1], so I'm not sure the bisection result is
reliable.

[1] https://lore.kernel.org/linux-nfs/6702796fee0365bf399800326bbe6c88e5f73f68.1689014440.git.bcodding@redhat.com/

  parent reply	other threads:[~2023-08-04 13:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-21 23:33 [PATCH net-next] tcx: Fix splat in ingress_destroy upon tcx_entry_free Daniel Borkmann
2023-07-22  1:40 ` Daniel Borkmann
2023-07-24 10:55 ` Petr Machata
2023-07-24 19:10 ` patchwork-bot+netdevbpf
2023-08-03 11:10 ` Gal Pressman
2023-08-03 23:48   ` Martin KaFai Lau
2023-08-06 13:47     ` Gal Pressman
2023-08-03 23:54   ` Daniel Borkmann
2023-08-06 13:50     ` Gal Pressman
2023-08-04 13:31   ` Ido Schimmel [this message]
2023-08-06 13:47     ` Gal Pressman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZMz9u+yZtk8vf+OP@shredder \
    --to=idosch@idosch.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=gal@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=syzbot+14736e249bce46091c18@syzkaller.appspotmail.com \
    --cc=syzbot+b202b7208664142954fa@syzkaller.appspotmail.com \
    --cc=syzbot+bdcf141f362ef83335cf@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).