From: Jiri Pirko <jiri@resnulli.us>
To: Zhengchao Shao <shaozhengchao@huawei.com>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
weiyongjun1@huawei.com, yuehaibing@huawei.com
Subject: Re: [PATCH net-next 0/2] team: change return value of init and getter in the team_option structure to void
Date: Fri, 4 Aug 2023 13:44:01 +0200 [thread overview]
Message-ID: <ZMzkgSQTDVhRe18v@nanopsycho> (raw)
In-Reply-To: <20230804112825.1697920-1-shaozhengchao@huawei.com>
Fri, Aug 04, 2023 at 01:28:23PM CEST, shaozhengchao@huawei.com wrote:
>Because the init and getter function always returns 0, so change return
>value of init and getter in the team_option structure to void and remove
>redundant code.
Reading this 5 times, I don't understand the sentence :/
Also, why you send 2 patchsets and 2 seperate patches, all for team? Why
don't you send it as one 6-patch patchset?
>
>Zhengchao Shao (2):
> team: change return value of init in the team_option structure to void
> team: change return value of getter in the team_option structure to
> void
>
> drivers/net/team/team.c | 60 +++++++++--------------
> drivers/net/team/team_mode_activebackup.c | 8 ++-
> drivers/net/team/team_mode_loadbalance.c | 39 ++++++---------
> include/linux/if_team.h | 4 +-
> 4 files changed, 44 insertions(+), 67 deletions(-)
>
>--
>2.34.1
>
next prev parent reply other threads:[~2023-08-04 11:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 11:28 [PATCH net-next 0/2] team: change return value of init and getter in the team_option structure to void Zhengchao Shao
2023-08-04 11:28 ` [PATCH net-next 1/2] team: change return value of init " Zhengchao Shao
2023-08-04 11:28 ` [PATCH net-next 2/2] team: change return value of getter " Zhengchao Shao
2023-08-04 11:44 ` Jiri Pirko [this message]
2023-08-04 12:06 ` [PATCH net-next 0/2] team: change return value of init and " shaozhengchao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMzkgSQTDVhRe18v@nanopsycho \
--to=jiri@resnulli.us \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shaozhengchao@huawei.com \
--cc=weiyongjun1@huawei.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox