From: Simon Horman <horms@kernel.org>
To: Manish Chopra <manishc@marvell.com>
Cc: kuba@kernel.org, netdev@vger.kernel.org, aelior@marvell.com,
palok@marvell.com, njavali@marvell.com, skashyap@marvell.com,
jmeneghi@redhat.com, yuval.mintz@qlogic.com,
skalluru@marvell.com, pabeni@redhat.com, edumazet@google.com,
horms@kernel.org, David Miller <davem@davemloft.net>
Subject: Re: [PATCH v3 net] qede: fix firmware halt over suspend and resume
Date: Thu, 17 Aug 2023 09:11:36 +0200 [thread overview]
Message-ID: <ZN3IKMw/lz0Extx0@vergenet.net> (raw)
In-Reply-To: <20230816150711.59035-1-manishc@marvell.com>
On Wed, Aug 16, 2023 at 08:37:11PM +0530, Manish Chopra wrote:
> While performing certain power-off sequences, PCI drivers are
> called to suspend and resume their underlying devices through
> PCI PM (power management) interface. However this NIC hardware
> does not support PCI PM suspend/resume operations so system wide
> suspend/resume leads to bad MFW (management firmware) state which
> causes various follow-up errors in driver when communicating with
> the device/firmware afterwards.
>
> To fix this driver implements PCI PM suspend handler to indicate
> unsupported operation to the PCI subsystem explicitly, thus avoiding
> system to go into suspended/standby mode.
>
> Without this fix device/firmware does not recover unless system
> is power cycled.
>
> Fixes: 2950219d87b0 ("qede: Add basic network device support")
> Cc: David Miller <davem@davemloft.net>
> Signed-off-by: Manish Chopra <manishc@marvell.com>
> Signed-off-by: Alok Prasad <palok@marvell.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2023-08-17 7:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 15:07 [PATCH v3 net] qede: fix firmware halt over suspend and resume Manish Chopra
2023-08-16 20:08 ` John Meneghini
2023-08-17 7:11 ` Simon Horman [this message]
2023-08-17 19:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZN3IKMw/lz0Extx0@vergenet.net \
--to=horms@kernel.org \
--cc=aelior@marvell.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jmeneghi@redhat.com \
--cc=kuba@kernel.org \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=njavali@marvell.com \
--cc=pabeni@redhat.com \
--cc=palok@marvell.com \
--cc=skalluru@marvell.com \
--cc=skashyap@marvell.com \
--cc=yuval.mintz@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).