netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Patrick Rohr <prohr@google.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	"Linux Network Development Mailing List" <netdev@vger.kernel.org>,
	"Maciej Żenczykowski" <maze@google.com>,
	"Lorenzo Colitti" <lorenzo@google.com>,
	"David Ahern" <dsahern@kernel.org>
Subject: Re: [netdev-next] net: release reference to inet6_dev pointer
Date: Fri, 18 Aug 2023 10:06:04 +0200	[thread overview]
Message-ID: <ZN8mbEnFGBCr3YLj@vergenet.net> (raw)
In-Reply-To: <20230816220203.1865432-1-prohr@google.com>

On Wed, Aug 16, 2023 at 03:02:03PM -0700, Patrick Rohr wrote:
> addrconf_prefix_rcv returned early without releasing the inet6_dev
> pointer when the PIO lifetime is less than accept_ra_min_lft.
> 
> Fixes: 5027d54a9c30 ("net: change accept_ra_min_rtr_lft to affect all RA lifetimes")
> Cc: Maciej Żenczykowski <maze@google.com>
> Cc: Lorenzo Colitti <lorenzo@google.com>
> Cc: David Ahern <dsahern@kernel.org>
> Signed-off-by: Patrick Rohr <prohr@google.com>

Hi Patrick,

this patch looks good to me, but unfortunately our CI got a bit
confused and tried to apply it to net, where it does not apply
because the cited commit is not present there, rather than
net-next, where it does apply. This creates a process issue for us.

I think it would be useful if you could repost the patch with
it targeted at net-next:

	Subject: [PATCH net-next] ...

Please feel free to include:

Reviewed-by: Simon Horman <horms@kernel.org>

-- 
pw-bot: changes-requested

  reply	other threads:[~2023-08-18  8:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-16 22:02 [netdev-next] net: release reference to inet6_dev pointer Patrick Rohr
2023-08-18  8:06 ` Simon Horman [this message]
2023-08-18  8:10   ` Maciej Żenczykowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZN8mbEnFGBCr3YLj@vergenet.net \
    --to=horms@kernel.org \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=lorenzo@google.com \
    --cc=maze@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=prohr@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).