From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8B0D17FE9 for ; Fri, 18 Aug 2023 12:15:59 +0000 (UTC) Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 677262705 for ; Fri, 18 Aug 2023 05:15:57 -0700 (PDT) Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-3fe426b8583so8148445e9.2 for ; Fri, 18 Aug 2023 05:15:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20221208.gappssmtp.com; s=20221208; t=1692360956; x=1692965756; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OCgI6ch4syeqbbC+MLzIQRbozJOcNueG12S2nRvRB3g=; b=KGYGlhrItx4oMmSB4E4B2wzb/G5KqQ+DsiHE/S2E0Fcdb9M514IWvfAz5bWmX0kkkU jA6Q9fXG/1WBSkflFBiyKUzwkCoHyCkH+TussngbRS/pOyuUtXjAeXXDX2Gy2q79867U Zk68Huw/zSfGKac6Y/MyBpp4WxU8YB9QhsqVN0P9A5juNcfJYVTP8xOPb0fW6LW0Yael eyHelAdxY2PXhdS6Dt+Zqdti4GPzcatjq6JKVPuCZNYVu1hnfmPqPaiPC0/LuIJNPe6w 1owBgxnKUAVkvlv7pRAWfMEn2bkzMYl/jKDsjKTDqy3uAExEjtBw0DkDFnTPxAhSHIrv qTCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692360956; x=1692965756; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OCgI6ch4syeqbbC+MLzIQRbozJOcNueG12S2nRvRB3g=; b=Gpvv0nlwSeRJqmoKPnfCEPoU2YxOhA13BaRYIqFyeAwKdPfAUT2hYstwJaw7l35vYM jBT3RAY7WtVj7FnBgqz13W05RmQ8ziqlLOFOlhB4w0tVEC60ewL5GqUGzn34Wt24fAXX 82fUfuNn40km2TMEnMtugi3VipRd/1CM8SYp4NtigFhhbc8WHELvJKua0mGidN+p3lN5 kcZArl4HnAPUFiDd/VgqelFCIUYo5mDwGnafVAvIM5jnOV1EO7zMS3R0H4+aOOWZJYW6 0CM61XNbPLBylK1dhejl+FQegvlf7BvechgtyCrdGyFiI5cIQSA1yZh7W8ZqhAx5pluT mW4Q== X-Gm-Message-State: AOJu0YxeKUfftt8mV9tx4cKXWzqrtYDNebn+DuQhITLN285YIQkaQYV5 maMExdUyfZBJFNTSfoG9ZodmTw== X-Google-Smtp-Source: AGHT+IGuKAK1hI1Rcu2KUZAzVgDhRfKGsoGfU42JO4C95xXOaGB/6yg7KFCSGqBCGUdbFR2BZLMhPg== X-Received: by 2002:a5d:650f:0:b0:317:5eb8:b1c4 with SMTP id x15-20020a5d650f000000b003175eb8b1c4mr2436993wru.2.1692360955747; Fri, 18 Aug 2023 05:15:55 -0700 (PDT) Received: from localhost ([212.23.236.67]) by smtp.gmail.com with ESMTPSA id l13-20020a5d410d000000b003142e438e8csm2629268wrp.26.2023.08.18.05.15.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Aug 2023 05:15:55 -0700 (PDT) Date: Fri, 18 Aug 2023 14:15:53 +0200 From: Jiri Pirko To: Justin Lai Cc: kuba@kernel.org, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next v5 1/2] net/ethernet/realtek: Add Realtek automotive PCIe driver code Message-ID: References: <20230818115501.209945-1-justinlai0215@realtek.com> <20230818115501.209945-2-justinlai0215@realtek.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230818115501.209945-2-justinlai0215@realtek.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Fri, Aug 18, 2023 at 01:55:00PM CEST, justinlai0215@realtek.com wrote: V>This patch is to add the ethernet device driver for the PCIe interface of Realtek Automotive Ethernet Switch, >applicable to RTL9054, RTL9068, RTL9072, RTL9075, RTL9068, RTL9071. > >Below is a simplified block diagram of the chip and its relevant interfaces. > > ************************* > * * > * CPU network device * > * ____________ * > * | | * > * | PCIE Host | * > ************************* > || > PCIE > || > **************************************** > * | PCIE Endpoint | * > * |---------------| * > * | GMAC | * > * |------| Realtek * > * || RTL90xx Series * > * || * > * _____________||______________ * > * | |MAC| | * > * | |---| | * > * | | * > * | Ethernet Switch Core | * > * | | * > * | ----- ----- | * > * | |MAC| ............|MAC| | * > * |__|___|_____________|___|____| * > * |PHY| ............|PHY| * > * ----- ----- * > *********||****************||*********** > >The block of the Realtek RTL90xx series is our entire chip architecture, the GMAC is connected to the switch core, >and there is no PHY in between. In addition, this driver is mainly used to control GMAC, but does not control the switch core, >so it is not the same as DSA. [..] >+ >+#define NETIF_F_ALL_CSUM NETIF_F_CSUM_MASK >+ >+#define NETIF_F_HW_VLAN_RX NETIF_F_HW_VLAN_CTAG_RX >+#define NETIF_F_HW_VLAN_TX NETIF_F_HW_VLAN_CTAG_TX [..] I see 3 essentials wrong from 10sec review: 1) You don't cc people who commented your previous versions 2) You don't respect 72cols for patch description text (checkpatch did warn you, didn't it?) 3) You are defining very odd macros like these 3 No need to read any longer... Really, can't you please ask someone who knows to help you with the submission preparation? You are vasting time of people :/