Re: [net-next 2/6] net: wwan: t7xx: Driver registers with Devlink framework

Jinjian Song
2023-08-05T12:12:42Z

Thu, Aug 03, 2023 at 04:18:08AM CEST, songjinjian@hotmail.com wrote:

[...]

>>+static const struct devlink_param t7xx_devlink_params[] = {
>>+ DEVLINK_PARAM_DRIVER(T7XX_DEVLINK_PARAM_ID_FASTBOOT,
>>+ "fastboot", DEVLINK_PARAM_TYPE_BOOL,
>>+ BIT(DEVLINK_PARAM_CMODE_DRIVERINIT),
>>+ NULL, NULL, NULL),
>
>driver init params is there so the user could configure driver instance
>and then hit devlink reload in order to reinitialize with the new param
>values. In your case, it is a device command. Does not make any sense to
>have it as param.
>
>NAK

Thanks for your review, so drop this param and set this param insider driver when driver_reinit,
is that fine?