From: Simon Horman <horms@kernel.org>
To: Guangguan Wang <guangguan.wang@linux.alibaba.com>
Cc: wenjia@linux.ibm.com, jaka@linux.ibm.com, kgraul@linux.ibm.com,
tonylu@linux.alibaba.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
horms@kernel.org, alibuda@linux.alibaba.com,
guwen@linux.alibaba.com, linux-s390@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 net-next 5/6] net/smc: support max links per lgr negotiation in clc handshake
Date: Mon, 7 Aug 2023 17:08:51 +0200 [thread overview]
Message-ID: <ZNEJA1E6ouOuaAcc@vergenet.net> (raw)
In-Reply-To: <20230807062720.20555-6-guangguan.wang@linux.alibaba.com>
On Mon, Aug 07, 2023 at 02:27:19PM +0800, Guangguan Wang wrote:
...
> diff --git a/net/smc/smc_llc.c b/net/smc/smc_llc.c
...
> @@ -1414,6 +1420,9 @@ int smc_llc_srv_add_link(struct smc_link *link,
> goto out;
> }
>
> + if (lgr->type == SMC_LGR_SINGLE && lgr->max_links <= 1)
Hi Guangguan Wang,
The function will return rc.
Should it be set to an error value here?
Flagged by Smatch.
> + goto out;
> +
> /* ignore client add link recommendation, start new flow */
> ini->vlan_id = lgr->vlan_id;
> if (lgr->smc_version == SMC_V2) {
> --
> 2.24.3 (Apple Git-128)
>
next prev parent reply other threads:[~2023-08-07 15:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 6:27 [RFC PATCH v2 net-next 0/6] net/smc: several features's implementation for smc v2.1 Guangguan Wang
2023-08-07 6:27 ` [RFC PATCH v2 net-next 1/6] net/smc: support smc release version negotiation in clc handshake Guangguan Wang
2023-08-09 16:03 ` Wenjia Zhang
2023-08-15 3:57 ` Guangguan Wang
2023-08-07 6:27 ` [RFC PATCH v2 net-next 2/6] net/smc: add vendor unique experimental options area " Guangguan Wang
2023-08-07 6:27 ` [RFC PATCH v2 net-next 3/6] net/smc: support smc v2.x features validate Guangguan Wang
2023-08-09 16:03 ` Wenjia Zhang
2023-08-15 3:59 ` Guangguan Wang
2023-08-07 6:27 ` [RFC PATCH v2 net-next 4/6] net/smc: support max connections per lgr negotiation Guangguan Wang
2023-08-09 16:04 ` Wenjia Zhang
2023-08-15 6:31 ` Guangguan Wang
2023-08-28 12:54 ` Wenjia Zhang
2023-08-29 2:31 ` Guangguan Wang
2023-08-29 13:18 ` Wenjia Zhang
2023-08-30 3:17 ` Guangguan Wang
2023-08-30 15:22 ` Wenjia Zhang
2023-08-07 6:27 ` [RFC PATCH v2 net-next 5/6] net/smc: support max links per lgr negotiation in clc handshake Guangguan Wang
2023-08-07 15:08 ` Simon Horman [this message]
2023-08-07 6:27 ` [RFC PATCH v2 net-next 6/6] net/smc: Extend SMCR v2 linkgroup netlink attribute Guangguan Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNEJA1E6ouOuaAcc@vergenet.net \
--to=horms@kernel.org \
--cc=alibuda@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=guangguan.wang@linux.alibaba.com \
--cc=guwen@linux.alibaba.com \
--cc=jaka@linux.ibm.com \
--cc=kgraul@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tonylu@linux.alibaba.com \
--cc=wenjia@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).