From: Ido Schimmel <idosch@idosch.org>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Ido Schimmel <idosch@nvidia.com>,
David Ahern <dsahern@kernel.org>,
Benjamin Poirier <bpoirier@nvidia.com>,
Thomas Haller <thaller@redhat.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCHv2 net-next 2/2] ipv4/fib: send notify when delete source address routes
Date: Thu, 10 Aug 2023 18:08:28 +0300 [thread overview]
Message-ID: <ZNT9bPpuCLVY7nnP@shredder> (raw)
In-Reply-To: <20230809140234.3879929-3-liuhangbin@gmail.com>
On Wed, Aug 09, 2023 at 10:02:34PM +0800, Hangbin Liu wrote:
> After deleting an interface address in fib_del_ifaddr(), the function
> scans the fib_info list for stray entries and calls fib_flush() and
> fib_table_flush(). Then the stray entries will be deleted silently and no
> RTM_DELROUTE notification will be sent.
>
> This lack of notification can make routing daemons like NetworkManager,
> miss the routing changes. e.g.
[...]
> To fix this issue, let's add a new bit in "struct fib_info" to track the
> deleted prefer source address routes, and only send notify for them.
In the other thread Thomas mentioned that NM already requests a route
dump following address deletion [1]. If so, can Thomas or you please
explain how this patch is going to help NM? Is the intention to optimize
things and avoid the dump request (which can only work on new kernels)?
[1] https://lore.kernel.org/netdev/07fcfd504148b3c721fda716ad0a549662708407.camel@redhat.com/
next prev parent reply other threads:[~2023-08-10 15:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 14:02 [PATCHv2 net-next 0/2] send notify when delete source address routes Hangbin Liu
2023-08-09 14:02 ` [PATCHv2 net-next 1/2] fib: convert fib_nh_is_v6 and nh_updated to use a single bit Hangbin Liu
2023-08-09 14:02 ` [PATCHv2 net-next 2/2] ipv4/fib: send notify when delete source address routes Hangbin Liu
2023-08-10 15:08 ` Ido Schimmel [this message]
2023-08-15 12:55 ` Hangbin Liu
2023-08-28 6:14 ` Hangbin Liu
2023-09-11 9:35 ` Thomas Haller
2023-09-12 2:30 ` Hangbin Liu
2023-09-13 9:59 ` Nicolas Dichtel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNT9bPpuCLVY7nnP@shredder \
--to=idosch@idosch.org \
--cc=bpoirier@nvidia.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stephen@networkplumber.org \
--cc=thaller@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).