From: Simon Horman <horms@kernel.org>
To: GUO Zihua <guozihua@huawei.com>
Cc: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
decui@microsoft.com, linux-hyperv@vger.kernel.org,
netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH -next] hv_netvsc: Remove duplicated include
Date: Fri, 11 Aug 2023 11:14:51 +0200 [thread overview]
Message-ID: <ZNX8CyvnsP0zhmbA@vergenet.net> (raw)
In-Reply-To: <20230810115148.21332-1-guozihua@huawei.com>
On Thu, Aug 10, 2023 at 07:51:48PM +0800, GUO Zihua wrote:
> Remove duplicated include of linux/slab.h. Resolves checkincludes message.
>
> Signed-off-by: GUO Zihua <guozihua@huawei.com>
The patch looks fine, but for reference, I do have some feedback
from a process point of view. It's probably not necessary to
repost because of these. But do keep them in mind if you have
to post a v2 for some other reason, and for future patch submissions.
* As a non bugfix for Networking code this should likely be targeted
at the net-next tree - the net tree is used for bug fixes.
And the target tree should be noted in the subject.
Subject: [PATCH net-next] ...
* Please use the following command to generate the
CC list for Networking patches
./scripts/get_maintainer.pl --git-min-percent 2 this.patch
In this case, the following, now CCed, should be included:
- Jakub Kicinski <kuba@kernel.org>
- Eric Dumazet <edumazet@google.com>
- "David S. Miller" <davem@davemloft.net>
- Paolo Abeni <pabeni@redhat.com>
* Please do read the process guide
https://kernel.org/doc/html/latest/process/maintainer-netdev.html
The above notwithstanding,
Reviewed-by: Simon Horman <horms@kernel.org>
> ---
> drivers/net/hyperv/rndis_filter.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c
> index af95947a87c5..ecc2128ca9b7 100644
> --- a/drivers/net/hyperv/rndis_filter.c
> +++ b/drivers/net/hyperv/rndis_filter.c
> @@ -21,7 +21,6 @@
> #include <linux/rtnetlink.h>
> #include <linux/ucs2_string.h>
> #include <linux/string.h>
> -#include <linux/slab.h>
>
> #include "hyperv_net.h"
> #include "netvsc_trace.h"
> --
> 2.17.1
>
>
next prev parent reply other threads:[~2023-08-11 9:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 11:51 [PATCH -next] hv_netvsc: Remove duplicated include GUO Zihua
2023-08-11 9:14 ` Simon Horman [this message]
2023-08-14 1:56 ` Guozihua (Scott)
2023-08-14 7:24 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNX8CyvnsP0zhmbA@vergenet.net \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=edumazet@google.com \
--cc=guozihua@huawei.com \
--cc=haiyangz@microsoft.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).