[PATCH -next] hv_netvsc: Remove duplicated include

[PATCH -next] hv_netvsc: Remove duplicated include

[GUO Zihua]

Remove duplicated include of linux/slab.h.  Resolves checkincludes message.

Signed-off-by: GUO Zihua <guozihua@huawei.com>
---
 drivers/net/hyperv/rndis_filter.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c
index af95947a87c5..ecc2128ca9b7 100644
--- a/drivers/net/hyperv/rndis_filter.c
+++ b/drivers/net/hyperv/rndis_filter.c
@@ -21,7 +21,6 @@
 #include <linux/rtnetlink.h>
 #include <linux/ucs2_string.h>
 #include <linux/string.h>
-#include <linux/slab.h>
 
 #include "hyperv_net.h"
 #include "netvsc_trace.h"
-- 
2.17.1

Re: [PATCH -next] hv_netvsc: Remove duplicated include

[Simon Horman]

On Thu, Aug 10, 2023 at 07:51:48PM +0800, GUO Zihua wrote:
> Remove duplicated include of linux/slab.h.  Resolves checkincludes message.
> 
> Signed-off-by: GUO Zihua <guozihua@huawei.com>

The patch looks fine, but for reference, I do have some feedback
from a process point of view. It's probably not necessary to
repost because of these. But do keep them in mind if you have
to post a v2 for some other reason, and for future patch submissions.

* As a non bugfix for Networking code this should likely be targeted
  at the net-next tree - the net tree is used for bug fixes.
  And the target tree should be noted in the subject.

  Subject: [PATCH net-next] ...

* Please use the following command to generate the
  CC list for Networking patches

  ./scripts/get_maintainer.pl --git-min-percent 2 this.patch

  In this case, the following, now CCed, should be included:

  - Jakub Kicinski <kuba@kernel.org>
  - Eric Dumazet <edumazet@google.com>
  - "David S. Miller" <davem@davemloft.net>
  - Paolo Abeni <pabeni@redhat.com>

* Please do read the process guide

  https://kernel.org/doc/html/latest/process/maintainer-netdev.html

The above notwithstanding,

Reviewed-by: Simon Horman <horms@kernel.org>

> ---
>  drivers/net/hyperv/rndis_filter.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c
> index af95947a87c5..ecc2128ca9b7 100644
> --- a/drivers/net/hyperv/rndis_filter.c
> +++ b/drivers/net/hyperv/rndis_filter.c
> @@ -21,7 +21,6 @@
>  #include <linux/rtnetlink.h>
>  #include <linux/ucs2_string.h>
>  #include <linux/string.h>
> -#include <linux/slab.h>
>  
>  #include "hyperv_net.h"
>  #include "netvsc_trace.h"
> -- 
> 2.17.1
> 
> 

Re: [PATCH -next] hv_netvsc: Remove duplicated include

[Guozihua (Scott)]

On 2023/8/11 17:14, Simon Horman wrote:
> On Thu, Aug 10, 2023 at 07:51:48PM +0800, GUO Zihua wrote:
>> Remove duplicated include of linux/slab.h.  Resolves checkincludes message.
>>
>> Signed-off-by: GUO Zihua <guozihua@huawei.com>
> 
> The patch looks fine, but for reference, I do have some feedback
> from a process point of view. It's probably not necessary to
> repost because of these. But do keep them in mind if you have
> to post a v2 for some other reason, and for future patch submissions.
> 
> * As a non bugfix for Networking code this should likely be targeted
>   at the net-next tree - the net tree is used for bug fixes.
>   And the target tree should be noted in the subject.
> 
>   Subject: [PATCH net-next] ...
> 
> * Please use the following command to generate the
>   CC list for Networking patches
> 
>   ./scripts/get_maintainer.pl --git-min-percent 2 this.patch
> 
>   In this case, the following, now CCed, should be included:
> 
>   - Jakub Kicinski <kuba@kernel.org>
>   - Eric Dumazet <edumazet@google.com>
>   - "David S. Miller" <davem@davemloft.net>
>   - Paolo Abeni <pabeni@redhat.com>
> 
> * Please do read the process guide
> 
>   https://kernel.org/doc/html/latest/process/maintainer-netdev.html
> 
> The above notwithstanding,
> 
> Reviewed-by: Simon Horman <horms@kernel.org>

Hi Simon,

Thanks for the info and the review-by! Will keep that in mind.

-- 
Best
GUO Zihua

Re: [PATCH -next] hv_netvsc: Remove duplicated include

[Simon Horman]

On Mon, Aug 14, 2023 at 09:56:11AM +0800, Guozihua (Scott) wrote:
> On 2023/8/11 17:14, Simon Horman wrote:
> > On Thu, Aug 10, 2023 at 07:51:48PM +0800, GUO Zihua wrote:
> >> Remove duplicated include of linux/slab.h.  Resolves checkincludes message.
> >>
> >> Signed-off-by: GUO Zihua <guozihua@huawei.com>
> > 
> > The patch looks fine, but for reference, I do have some feedback
> > from a process point of view. It's probably not necessary to
> > repost because of these. But do keep them in mind if you have
> > to post a v2 for some other reason, and for future patch submissions.
> > 
> > * As a non bugfix for Networking code this should likely be targeted
> >   at the net-next tree - the net tree is used for bug fixes.
> >   And the target tree should be noted in the subject.
> > 
> >   Subject: [PATCH net-next] ...
> > 
> > * Please use the following command to generate the
> >   CC list for Networking patches
> > 
> >   ./scripts/get_maintainer.pl --git-min-percent 2 this.patch

It seems that I made a typo here, it should be:

	./scripts/get_maintainer.pl --git-min-percent 25 this.patch

	n.b: 2 -> 25

> > 
> >   In this case, the following, now CCed, should be included:
> > 
> >   - Jakub Kicinski <kuba@kernel.org>
> >   - Eric Dumazet <edumazet@google.com>
> >   - "David S. Miller" <davem@davemloft.net>
> >   - Paolo Abeni <pabeni@redhat.com>
> > 
> > * Please do read the process guide
> > 
> >   https://kernel.org/doc/html/latest/process/maintainer-netdev.html
> > 
> > The above notwithstanding,
> > 
> > Reviewed-by: Simon Horman <horms@kernel.org>
> 
> Hi Simon,
> 
> Thanks for the info and the review-by! Will keep that in mind.
> 
> -- 
> Best
> GUO Zihua
>