From: Jiri Pirko <jiri@resnulli.us>
To: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Cc: Jakub Kicinski <kuba@kernel.org>,
Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
Jonathan Lemon <jonathan.lemon@gmail.com>,
Paolo Abeni <pabeni@redhat.com>,
Milena Olech <milena.olech@intel.com>,
Michal Michalik <michal.michalik@intel.com>,
linux-arm-kernel@lists.infradead.org, poros@redhat.com,
mschmidt@redhat.com, netdev@vger.kernel.org,
linux-clk@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>,
intel-wired-lan@lists.osuosl.org, Jiri Pirko <jiri@nvidia.com>
Subject: Re: [PATCH net-next v4 7/9] ice: implement dpll interface to control cgu
Date: Sat, 12 Aug 2023 08:19:45 +0200 [thread overview]
Message-ID: <ZNckgQzRO6uSvnaV@nanopsycho> (raw)
In-Reply-To: <20230811200340.577359-8-vadim.fedorenko@linux.dev>
Fri, Aug 11, 2023 at 10:03:38PM CEST, vadim.fedorenko@linux.dev wrote:
[...]
>@@ -4690,6 +4694,8 @@ static void ice_deinit_features(struct ice_pf *pf)
> ice_gnss_exit(pf);
> if (test_bit(ICE_FLAG_PTP_SUPPORTED, pf->flags))
> ice_ptp_release(pf);
>+ if (test_bit(ICE_FLAG_DPLL, pf->flags))
This is a duplicate test as you test it as a first thing in
ice_dpll_deinit(). But nevermind this nit, let's have v4 merged
if possible.
>+ ice_dpll_deinit(pf);
> }
>
> static void ice_init_wakeup(struct ice_pf *pf)
>--
>2.27.0
>
next prev parent reply other threads:[~2023-08-12 6:19 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 20:03 [PATCH net-next v4 0/9] Create common DPLL configuration API Vadim Fedorenko
2023-08-11 20:03 ` [PATCH net-next v4 1/9] dpll: documentation on DPLL subsystem interface Vadim Fedorenko
2023-08-15 2:52 ` Jakub Kicinski
2023-08-11 20:03 ` [PATCH net-next v4 2/9] dpll: spec: Add Netlink spec in YAML Vadim Fedorenko
2023-08-15 2:43 ` Jakub Kicinski
2023-08-17 18:40 ` Kubalewski, Arkadiusz
2023-08-17 23:36 ` Jakub Kicinski
2023-08-18 7:23 ` Jiri Pirko
2023-08-21 10:15 ` Kubalewski, Arkadiusz
2023-08-22 16:54 ` Jakub Kicinski
2023-08-11 20:03 ` [PATCH net-next v4 3/9] dpll: core: Add DPLL framework base functions Vadim Fedorenko
2023-08-15 3:17 ` Jakub Kicinski
2023-08-15 6:00 ` Jiri Pirko
2023-08-15 18:20 ` Vadim Fedorenko
2023-08-15 18:28 ` Jakub Kicinski
2023-08-15 18:38 ` Vadim Fedorenko
2023-08-11 20:03 ` [PATCH net-next v4 4/9] dpll: netlink: " Vadim Fedorenko
2023-08-15 3:23 ` Jakub Kicinski
2023-08-15 3:24 ` Jakub Kicinski
2023-08-15 15:18 ` Vadim Fedorenko
2023-08-15 16:55 ` Jakub Kicinski
2023-08-15 18:25 ` Vadim Fedorenko
2023-08-11 20:03 ` [PATCH net-next v4 5/9] netdev: expose DPLL pin handle for netdevice Vadim Fedorenko
2023-08-11 20:03 ` [PATCH net-next v4 6/9] ice: add admin commands to access cgu configuration Vadim Fedorenko
2023-08-11 20:03 ` [PATCH net-next v4 7/9] ice: implement dpll interface to control cgu Vadim Fedorenko
2023-08-12 6:19 ` Jiri Pirko [this message]
2023-08-11 20:03 ` [PATCH net-next v4 8/9] ptp_ocp: implement DPLL ops Vadim Fedorenko
2023-08-11 20:03 ` [PATCH net-next v4 9/9] mlx5: Implement SyncE support using DPLL infrastructure Vadim Fedorenko
2023-08-12 6:22 ` [PATCH net-next v4 0/9] Create common DPLL configuration API Jiri Pirko
2023-08-12 11:20 ` Vadim Fedorenko
2023-08-15 2:45 ` Jakub Kicinski
2023-08-15 11:36 ` Vadim Fedorenko
2023-08-15 11:52 ` Jiri Pirko
2023-08-15 14:32 ` Vadim Fedorenko
2023-08-15 17:02 ` Jakub Kicinski
2023-08-18 10:15 ` Kubalewski, Arkadiusz
2023-08-18 21:03 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNckgQzRO6uSvnaV@nanopsycho \
--to=jiri@resnulli.us \
--cc=arkadiusz.kubalewski@intel.com \
--cc=bvanassche@acm.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jiri@nvidia.com \
--cc=jonathan.lemon@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=michal.michalik@intel.com \
--cc=milena.olech@intel.com \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=poros@redhat.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).