From: Ido Schimmel <idosch@idosch.org>
To: Vlad Buslov <vladbu@nvidia.com>
Cc: davem@davemloft.net, kuba@kernel.org, edumazet@google.com,
pabeni@redhat.com, netdev@vger.kernel.org,
amir.hanania@intel.com, jeffrey.t.kirsher@intel.com,
john.fastabend@gmail.com, horms@kernel.org,
syzbot+662f783a5cdf3add2719@syzkaller.appspotmail.com,
syzbot+4b4f06495414e92701d5@syzkaller.appspotmail.com,
syzbot+d810d3cd45ed1848c3f7@syzkaller.appspotmail.com
Subject: Re: [PATCH net] Revert "vlan: Fix VLAN 0 memory leak"
Date: Sun, 13 Aug 2023 10:39:54 +0300 [thread overview]
Message-ID: <ZNiIyjStj71S5/Rs@shredder> (raw)
In-Reply-To: <20230811154523.1877590-1-vladbu@nvidia.com>
On Fri, Aug 11, 2023 at 05:45:23PM +0200, Vlad Buslov wrote:
> This reverts commit 718cb09aaa6fa78cc8124e9517efbc6c92665384.
>
> The commit triggers multiple syzbot issues, probably due to possibility of
> manually creating VLAN 0 on netdevice which will cause the code to delete
> it since it can't distinguish such VLAN from implicit VLAN 0 automatically
> created for devices with NETIF_F_HW_VLAN_CTAG_FILTER feature.
>
> Reported-by: syzbot+662f783a5cdf3add2719@syzkaller.appspotmail.com
> Closes: https://lore.kernel.org/all/00000000000090196d0602a6167d@google.com/
> Reported-by: syzbot+4b4f06495414e92701d5@syzkaller.appspotmail.com
> Closes: https://lore.kernel.org/all/00000000000096ae870602a61602@google.com/
> Reported-by: syzbot+d810d3cd45ed1848c3f7@syzkaller.appspotmail.com
> Closes: https://lore.kernel.org/all/0000000000009f0f9c0602a616ce@google.com/
> Fixes: 718cb09aaa6f ("vlan: Fix VLAN 0 memory leak")
> Signed-off-by: Vlad Buslov <vladbu@nvidia.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
next prev parent reply other threads:[~2023-08-13 7:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 15:45 [PATCH net] Revert "vlan: Fix VLAN 0 memory leak" Vlad Buslov
2023-08-13 7:39 ` Ido Schimmel [this message]
2023-08-14 7:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNiIyjStj71S5/Rs@shredder \
--to=idosch@idosch.org \
--cc=amir.hanania@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+4b4f06495414e92701d5@syzkaller.appspotmail.com \
--cc=syzbot+662f783a5cdf3add2719@syzkaller.appspotmail.com \
--cc=syzbot+d810d3cd45ed1848c3f7@syzkaller.appspotmail.com \
--cc=vladbu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).