netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: "Guozihua (Scott)" <guozihua@huawei.com>
Cc: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
	decui@microsoft.com, linux-hyperv@vger.kernel.org,
	netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
	Eric Dumazet <edumazet@google.com>,
	"David S. Miller" <davem@davemloft.net>,
	Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH -next] hv_netvsc: Remove duplicated include
Date: Mon, 14 Aug 2023 09:24:54 +0200	[thread overview]
Message-ID: <ZNnWxiOySLDBN5AA@vergenet.net> (raw)
In-Reply-To: <d7a6c71a-98a6-64cd-8118-2b0f89189177@huawei.com>

On Mon, Aug 14, 2023 at 09:56:11AM +0800, Guozihua (Scott) wrote:
> On 2023/8/11 17:14, Simon Horman wrote:
> > On Thu, Aug 10, 2023 at 07:51:48PM +0800, GUO Zihua wrote:
> >> Remove duplicated include of linux/slab.h.  Resolves checkincludes message.
> >>
> >> Signed-off-by: GUO Zihua <guozihua@huawei.com>
> > 
> > The patch looks fine, but for reference, I do have some feedback
> > from a process point of view. It's probably not necessary to
> > repost because of these. But do keep them in mind if you have
> > to post a v2 for some other reason, and for future patch submissions.
> > 
> > * As a non bugfix for Networking code this should likely be targeted
> >   at the net-next tree - the net tree is used for bug fixes.
> >   And the target tree should be noted in the subject.
> > 
> >   Subject: [PATCH net-next] ...
> > 
> > * Please use the following command to generate the
> >   CC list for Networking patches
> > 
> >   ./scripts/get_maintainer.pl --git-min-percent 2 this.patch

It seems that I made a typo here, it should be:

	./scripts/get_maintainer.pl --git-min-percent 25 this.patch

	n.b: 2 -> 25

> > 
> >   In this case, the following, now CCed, should be included:
> > 
> >   - Jakub Kicinski <kuba@kernel.org>
> >   - Eric Dumazet <edumazet@google.com>
> >   - "David S. Miller" <davem@davemloft.net>
> >   - Paolo Abeni <pabeni@redhat.com>
> > 
> > * Please do read the process guide
> > 
> >   https://kernel.org/doc/html/latest/process/maintainer-netdev.html
> > 
> > The above notwithstanding,
> > 
> > Reviewed-by: Simon Horman <horms@kernel.org>
> 
> Hi Simon,
> 
> Thanks for the info and the review-by! Will keep that in mind.
> 
> -- 
> Best
> GUO Zihua
> 

      reply	other threads:[~2023-08-14  7:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-10 11:51 [PATCH -next] hv_netvsc: Remove duplicated include GUO Zihua
2023-08-11  9:14 ` Simon Horman
2023-08-14  1:56   ` Guozihua (Scott)
2023-08-14  7:24     ` Simon Horman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZNnWxiOySLDBN5AA@vergenet.net \
    --to=horms@kernel.org \
    --cc=davem@davemloft.net \
    --cc=decui@microsoft.com \
    --cc=edumazet@google.com \
    --cc=guozihua@huawei.com \
    --cc=haiyangz@microsoft.com \
    --cc=kuba@kernel.org \
    --cc=kys@microsoft.com \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=wei.liu@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).