From: Ido Schimmel <idosch@idosch.org>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Thomas Haller <thaller@redhat.com>
Subject: Re: [PATCHv5 net-next] ipv6: do not match device when remove source route
Date: Mon, 14 Aug 2023 19:20:28 +0300 [thread overview]
Message-ID: <ZNpUTLvUqtp5rEzR@shredder> (raw)
In-Reply-To: <ZNnm4UOszRN6TOHJ@Laptop-X1>
On Mon, Aug 14, 2023 at 04:33:37PM +0800, Hangbin Liu wrote:
> I will remove the tb id checking in next version. Another thing to confirm.
> We need remove the "!rt->nh" checking, right. Because I saw you kept it in you
> reply.
My understanding is that when the route uses a nexthop object (i.e.,
rt->nh is not NULL), then rt->fib6_nh is invalid. So I think we need the
check for now. Maybe it can be removed once the function learns to use
nexthop_fib6_nh() for routes with a nexthop object, but that's another
patch. Let's finish with the current problem first.
prev parent reply other threads:[~2023-08-14 16:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 9:53 [PATCHv5 net-next] ipv6: do not match device when remove source route Hangbin Liu
2023-08-13 16:09 ` Ido Schimmel
2023-08-14 8:33 ` Hangbin Liu
2023-08-14 16:13 ` David Ahern
2023-08-14 16:20 ` Ido Schimmel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNpUTLvUqtp5rEzR@shredder \
--to=idosch@idosch.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thaller@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox