From: Jiri Pirko <jiri@resnulli.us>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, johannes@sipsolutions.net,
Vladimir Oltean <vladimir.oltean@nxp.com>,
gal@nvidia.com, tariqt@nvidia.com, lucien.xin@gmail.com,
f.fainelli@gmail.com, andrew@lunn.ch, simon.horman@corigine.com,
linux@rempel-privat.de, mkubecek@suse.cz
Subject: Re: [PATCH net-next v3 10/10] ethtool: netlink: always pass genl_info to .prepare_data
Date: Tue, 15 Aug 2023 08:06:53 +0200 [thread overview]
Message-ID: <ZNsV/ZFsixC2CRPW@nanopsycho> (raw)
In-Reply-To: <20230814214723.2924989-11-kuba@kernel.org>
Mon, Aug 14, 2023 at 11:47:23PM CEST, kuba@kernel.org wrote:
>We had a number of bugs in the past because developers forgot
>to fully test dumps, which pass NULL as info to .prepare_data.
>.prepare_data implementations would try to access info->extack
>leading to a null-deref.
>
>Now that dumps and notifications can access struct genl_info
>we can pass it in, and remove the info null checks.
>
>Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
>Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com> # pause
>Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
next prev parent reply other threads:[~2023-08-15 6:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 21:47 [PATCH net-next v3 00/10] genetlink: provide struct genl_info to dumps Jakub Kicinski
2023-08-14 21:47 ` [PATCH net-next v3 01/10] genetlink: push conditional locking into dumpit/done Jakub Kicinski
2023-08-14 21:47 ` [PATCH net-next v3 02/10] genetlink: make genl_info->nlhdr const Jakub Kicinski
2023-08-14 21:47 ` [PATCH net-next v3 03/10] genetlink: remove userhdr from struct genl_info Jakub Kicinski
2023-08-15 12:49 ` [ovs-dev] " Aaron Conole
2023-08-14 21:47 ` [PATCH net-next v3 04/10] genetlink: add struct genl_info to struct genl_dumpit_info Jakub Kicinski
2023-08-14 21:47 ` [PATCH net-next v3 05/10] genetlink: use attrs from struct genl_info Jakub Kicinski
2023-08-15 21:46 ` kernel test robot
2023-08-14 21:47 ` [PATCH net-next v3 06/10] genetlink: add a family pointer to " Jakub Kicinski
2023-08-14 21:47 ` [PATCH net-next v3 07/10] genetlink: add genlmsg_iput() API Jakub Kicinski
2023-08-14 21:47 ` [PATCH net-next v3 08/10] netdev-genl: use struct genl_info for reply construction Jakub Kicinski
2023-08-14 21:47 ` [PATCH net-next v3 09/10] ethtool: netlink: simplify arguments to ethnl_default_parse() Jakub Kicinski
2023-08-14 21:47 ` [PATCH net-next v3 10/10] ethtool: netlink: always pass genl_info to .prepare_data Jakub Kicinski
2023-08-15 6:06 ` Jiri Pirko [this message]
2023-08-15 22:10 ` [PATCH net-next v3 00/10] genetlink: provide struct genl_info to dumps patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNsV/ZFsixC2CRPW@nanopsycho \
--to=jiri@resnulli.us \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=gal@nvidia.com \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux@rempel-privat.de \
--cc=lucien.xin@gmail.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
--cc=tariqt@nvidia.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox