From: Simon Horman <horms@kernel.org>
To: Ziyang Xuan <william.xuanziyang@huawei.com>
Cc: jiri@resnulli.us, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
idosch@idosch.org, kaber@trash.net
Subject: Re: [PATCH net] team: Fix incorrect deletion of ETH_P_8021AD protocol vid from slaves
Date: Tue, 15 Aug 2023 10:08:56 +0200 [thread overview]
Message-ID: <ZNsymO9HyhmFhDCJ@vergenet.net> (raw)
In-Reply-To: <20230814032301.2804971-1-william.xuanziyang@huawei.com>
On Mon, Aug 14, 2023 at 11:23:01AM +0800, Ziyang Xuan wrote:
> Similar to commit 01f4fd270870 ("bonding: Fix incorrect deletion of
> ETH_P_8021AD protocol vid from slaves"), we can trigger BUG_ON(!vlan_info)
> in unregister_vlan_dev() with the following testcase:
>
> # ip netns add ns1
> # ip netns exec ns1 ip link add team1 type team
> # ip netns exec ns1 ip link add team_slave type veth peer veth2
> # ip netns exec ns1 ip link set team_slave master team1
> # ip netns exec ns1 ip link add link team_slave name team_slave.10 type vlan id 10 protocol 802.1ad
> # ip netns exec ns1 ip link add link team1 name team1.10 type vlan id 10 protocol 802.1ad
> # ip netns exec ns1 ip link set team_slave nomaster
> # ip netns del ns1
>
> Add S-VLAN tag related features support to team driver. So the team driver
> will always propagate the VLAN info to its slaves.
>
> Fixes: 8ad227ff89a7 ("net: vlan: add 802.1ad support")
> Suggested-by: Ido Schimmel <idosch@idosch.org>
> Signed-off-by: Ziyang Xuan <william.xuanziyang@huawei.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2023-08-15 8:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 3:23 [PATCH net] team: Fix incorrect deletion of ETH_P_8021AD protocol vid from slaves Ziyang Xuan
2023-08-15 8:08 ` Simon Horman [this message]
2023-08-16 2:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNsymO9HyhmFhDCJ@vergenet.net \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@idosch.org \
--cc=jiri@resnulli.us \
--cc=kaber@trash.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=william.xuanziyang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).