Netdev List
 help / color / mirror / Atom feed
From: Hangbin Liu <liuhangbin@gmail.com>
To: shaozhengchao <shaozhengchao@huawei.com>
Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
	shuah@kernel.org, j.vosburgh@gmail.com, andy@greyhouse.net,
	weiyongjun1@huawei.com, yuehaibing@huawei.com
Subject: Re: [PATCH net-next] selftests: bonding: remove redundant delete action of device link1_1
Date: Wed, 16 Aug 2023 16:33:11 +0800	[thread overview]
Message-ID: <ZNyJx1HtXaUzOkNA@Laptop-X1> (raw)
In-Reply-To: <a363d616-eadb-2136-a445-f946c24cd66d@huawei.com>

On Wed, Aug 16, 2023 at 03:55:30PM +0800, shaozhengchao wrote:
> 
> 
> On 2023/8/16 14:11, Hangbin Liu wrote:
> > On Sat, Aug 12, 2023 at 04:40:36PM +0800, Zhengchao Shao wrote:
> > > When run command "ip netns delete client", device link1_1 has been
> > > deleted. So, it is no need to delete link1_1 again. Remove it.
> > 
> Hi Hangbin:
> > What if the test exit because the cmd execute failed before setting
> > link1_1 to netns client?
> > 
> > Thanks
> > Hangbin
> > > 
> 	Your consideration is indeed possible.
> "ip link del link1_1 >/dev/null 2>&1" maybe looks better?

I have not objects to this. On the other side, this only omit the error
message. It doesn't fix anything.

Thanks
Hangbin

  reply	other threads:[~2023-08-16  8:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-12  8:40 [PATCH net-next] selftests: bonding: remove redundant delete action of device link1_1 Zhengchao Shao
2023-08-16  6:10 ` patchwork-bot+netdevbpf
2023-08-16  6:11 ` Hangbin Liu
2023-08-16  7:55   ` shaozhengchao
2023-08-16  8:33     ` Hangbin Liu [this message]
2023-08-16  9:22       ` shaozhengchao
2023-08-16 10:02         ` Hangbin Liu
2023-08-16 13:48           ` shaozhengchao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZNyJx1HtXaUzOkNA@Laptop-X1 \
    --to=liuhangbin@gmail.com \
    --cc=andy@greyhouse.net \
    --cc=j.vosburgh@gmail.com \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=shaozhengchao@huawei.com \
    --cc=shuah@kernel.org \
    --cc=weiyongjun1@huawei.com \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox