From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DF171548D for ; Tue, 29 Aug 2023 11:22:35 +0000 (UTC) Received: from pandora.armlinux.org.uk (unknown [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2899FEC; Tue, 29 Aug 2023 04:22:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=PELaoVV7DrLQuw/lZUSO2dRCS1U1CaoichWPb1NElTg=; b=mpIHSsXqZ4rZGh/CuOhBIfWINX 4ECohFkyxlPwfm2JVgHB3l1f74zk0rtZvaBaLrkD0qEw5xRRz+LyjqEP82k2ACDwODPvJgOflO5Mn 08NaEDIHMdsZEVrhYVxJW2EZdgAKCUrt0lGfXHluZ77fTCTJKSCd5pcMwXzZV68sljBg6rD89SL6Z 2LF91nyxSuXzQCwR3nunWdownszEM6gjvXbHw46muymwLS+cuWA8oruoey7Qz3ZMPbiymHE82hdnl hXsNKOrj+Im/OWSZOcSa9+NjYtJuGq4XLmONtTDhgU3QOTouo83KhJKbF7exisFdVQD9rddqGtVcq 6h3dHBzw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:55738) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qawmw-0000OF-38; Tue, 29 Aug 2023 12:21:39 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qawmn-0004bN-Q4; Tue, 29 Aug 2023 12:21:29 +0100 Date: Tue, 29 Aug 2023 12:21:29 +0100 From: "Russell King (Oracle)" To: Jisheng Zhang Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Emil Renner Berthing , Samin Guo , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Thierry Reding , Jonathan Hunter , Nobuhiro Iwamatsu , Matthias Brugger , AngeloGioacchino Del Regno , Bartosz Golaszewski , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 00/22] convert to devm_stmmac_probe_config_dt Message-ID: References: <20230829104033.955-1-jszhang@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230829104033.955-1-jszhang@kernel.org> Sender: Russell King (Oracle) X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,RDNS_NONE, SPF_HELO_NONE,SPF_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Tue, Aug 29, 2023 at 06:40:11PM +0800, Jisheng Zhang wrote: > Russell pointed out there's a new devm_stmmac_probe_config_dt() > helper now when reviewing my starfive gmac error handling patch[1]. > After greping the code, this nice helper was introduced by Bartosz in > [2], I think it's time to convert all dwmac users to this helper and > finally complete the TODO in [2] "but once all users of the old > stmmac_pltfr_remove() are converted to the devres helper, it will be > renamed back to stmmac_pltfr_remove() and the no_dt function removed." I think a useful final patch may be to make stmmac_probe_config_dt() static so there aren't any new uses of stmmac_probe_config_dt(). Also note that net-next is now closed, so please wait until after -rc1 for net-next to re-open, or post as RFC. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!