From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sergey Ryazanov <ryazanov.s.a@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
haozhe chang <haozhe.chang@mediatek.com>,
Loic Poulain <loic.poulain@linaro.org>,
Johannes Berg <johannes@sipsolutions.net>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next v1 1/1] wwan: core: Use the bitmap API to allocate bitmaps
Date: Tue, 29 Aug 2023 16:24:36 +0300 [thread overview]
Message-ID: <ZO3xlJ/7WDCDuz2T@smile.fi.intel.com> (raw)
In-Reply-To: <689ae7b5-0b73-3cb3-5d9c-5ae23e36ee85@gmail.com>
On Mon, Aug 28, 2023 at 09:06:09PM +0300, Sergey Ryazanov wrote:
> On 28.08.2023 16:19, Andy Shevchenko wrote:
> > Use bitmap_zalloc() and bitmap_free() instead of hand-writing them.
> > It is less verbose and it improves the type checking and semantic.
> >
> > While at it, add missing header inclusion (should be bitops.h,
> > but with the above change it becomes bitmap.h).
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Make sense. Thank you.
>
> BTW, any plans to update __dev_alloc_name(), which was used as reference, in
> the same way?
Ah, will look at it, thanks for the pointer.
> Reviewed-by: Sergey Ryazanov <ryazanov.s.a@gmail.com>
And thank you for the review!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-29 13:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 13:19 [PATCH net-next v1 1/1] wwan: core: Use the bitmap API to allocate bitmaps Andy Shevchenko
2023-08-28 18:06 ` Sergey Ryazanov
2023-08-29 13:24 ` Andy Shevchenko [this message]
2023-08-28 19:45 ` Jakub Kicinski
2023-08-29 13:26 ` Andy Shevchenko
2023-08-30 13:48 ` Loic Poulain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZO3xlJ/7WDCDuz2T@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=haozhe.chang@mediatek.com \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ryazanov.s.a@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).