From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32A334406 for ; Wed, 30 Aug 2023 11:08:35 +0000 (UTC) Received: from pandora.armlinux.org.uk (unknown [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40FCACC9; Wed, 30 Aug 2023 04:08:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=9V7gLBLZ4ZKefaxWBsYfcwRLnheQHNxgytolgk5UJx4=; b=MOSJKQtbd3z7WPVenT49uuXaP8 pcvv3LZSs7xeMW/5TFV6whOaDHFr6OGbp/dgpY220yaXJJs70jzdRj+WADcWn/QNzxParn7yPr6xp SWxxIM/Za2OgGmJd9egkK39QaBiRpBk6cOsoR9r70Y4Lia/lHPx0i3YG4y9rnRm0pD52/QnqIABqJ ScGYmAIIIEVIRQj++xzfQEL7HP6RFI6R0ZpzYQ78MVdYWr2+uij4WilA2SM6uJSC8BoWYbBoFZUF2 Poj1CPIvkrDAWCzLZu8X+kE8FH8FJiMBj+XpKW+cnKWtL7j7EDSEkOm0JKlpiieaQzCAKqBCG41+L DTDPYXLg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:42286) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qbJ3a-0001Us-2S; Wed, 30 Aug 2023 12:08:18 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qbJ3Z-0005cg-M8; Wed, 30 Aug 2023 12:08:17 +0100 Date: Wed, 30 Aug 2023 12:08:17 +0100 From: "Russell King (Oracle)" To: Lukasz Majewski Cc: Eric Dumazet , Andrew Lunn , davem@davemloft.net, Woojung Huh , Vladimir Oltean , Oleksij Rempel , Tristram.Ha@microchip.com, Florian Fainelli , Jakub Kicinski , Paolo Abeni , UNGLinuxDriver@microchip.com, Heiner Kallweit , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] net: phy: Provide Module 4 KSZ9477 errata (DS80000754C) Message-ID: References: <20230830092119.458330-1-lukma@denx.de> <20230830092119.458330-2-lukma@denx.de> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230830092119.458330-2-lukma@denx.de> Sender: Russell King (Oracle) X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,RDNS_NONE, SPF_HELO_NONE,SPF_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Wed, Aug 30, 2023 at 11:21:19AM +0200, Lukasz Majewski wrote: > + /* KSZ9477 Errata DS80000754C > + * > + * Module 4: Energy Efficient Ethernet (EEE) feature select must be > + * manually disabled > + * The EEE feature is enabled by default, but it is not fully > + * operational. It must be manually disabled through register > + * controls. If not disabled, the PHY ports can auto-negotiate > + * to enable EEE, and this feature can cause link drops when linked > + * to another device supporting EEE. > + * > + * Although, the KSZ9477 MMD register > + * (MMD_DEVICE_ID_EEE_ADV.MMD_EEE_ADV) advertise that EEE is > + * operational one needs to manualy clear them to follow the chip > + * errata. > + */ > + linkmode_and(phydev->supported_eee, phydev->supported, zero); Hi, I'm wondering whether you had a reason to write the above, rather than use the simpler: linkmode_zero(phydev->supported_eee); Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!