From: Ido Schimmel <idosch@idosch.org>
To: Florian Westphal <fw@strlen.de>
Cc: netdev@vger.kernel.org, Stanislav Fomichev <sdf@google.com>,
David Ahern <dsahern@kernel.org>,
Ido Schimmel <idosch@nvidia.com>
Subject: Re: [PATCH net] net: fib: avoid warn splat in flow dissector
Date: Wed, 30 Aug 2023 17:46:44 +0300 [thread overview]
Message-ID: <ZO9WVHlbL7a0qwxx@shredder> (raw)
In-Reply-To: <20230830110043.30497-1-fw@strlen.de>
On Wed, Aug 30, 2023 at 01:00:37PM +0200, Florian Westphal wrote:
> New skbs allocated via nf_send_reset() have skb->dev == NULL.
>
> fib*_rules_early_flow_dissect helpers already have a 'struct net'
> argument but its not passed down to the flow dissector core, which
> will then WARN as it can't derive a net namespace to use:
>
> WARNING: CPU: 0 PID: 0 at net/core/flow_dissector.c:1016 __skb_flow_dissect+0xa91/0x1cd0
> [..]
> ip_route_me_harder+0x143/0x330
> nf_send_reset+0x17c/0x2d0 [nf_reject_ipv4]
> nft_reject_inet_eval+0xa9/0xf2 [nft_reject_inet]
> nft_do_chain+0x198/0x5d0 [nf_tables]
> nft_do_chain_inet+0xa4/0x110 [nf_tables]
> nf_hook_slow+0x41/0xc0
> ip_local_deliver+0xce/0x110
> ..
>
> Cc: Stanislav Fomichev <sdf@google.com>
> Cc: David Ahern <dsahern@kernel.org>
> Cc: Ido Schimmel <idosch@nvidia.com>
> Fixes: 812fa71f0d96 ("netfilter: Dissect flow after packet mangling")
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=217826
> Signed-off-by: Florian Westphal <fw@strlen.de>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Thanks!
next prev parent reply other threads:[~2023-08-30 14:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 11:00 [PATCH net] net: fib: avoid warn splat in flow dissector Florian Westphal
2023-08-30 14:46 ` Ido Schimmel [this message]
2023-08-30 14:56 ` David Ahern
2023-08-31 11:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZO9WVHlbL7a0qwxx@shredder \
--to=idosch@idosch.org \
--cc=dsahern@kernel.org \
--cc=fw@strlen.de \
--cc=idosch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=sdf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).