From: Ido Schimmel <idosch@idosch.org>
To: "Drewek, Wojciech" <wojciech.drewek@intel.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Kitszel, Przemyslaw" <przemyslaw.kitszel@intel.com>,
"idosch@nvidia.com" <idosch@nvidia.com>
Subject: Re: [PATCH iwl-next v2] ice: Disable Cage Max Power override
Date: Wed, 30 Aug 2023 18:17:27 +0300 [thread overview]
Message-ID: <ZO9dhzhK+psufXqS@shredder> (raw)
In-Reply-To: <MW4PR11MB57766C3B9C05C94F51630251FDE7A@MW4PR11MB5776.namprd11.prod.outlook.com>
On Tue, Aug 29, 2023 at 09:12:22AM +0000, Drewek, Wojciech wrote:
> In some cases users are trying to use media with power exceeding max allowed value.
> Port split require system reboot so it feels natural to me to restore default settings.
I don't believe it's the kernel's responsibility to undo changes done by
external tools. Given that the tool is able to change this setting, I
assume it can also restore it back to default.
Moreover, it doesn't sound like port split won't work without this
change, so placing this change there only because we assume that a
reboot will follow seems random.
I think the best way forward is to extend ethtool as was already
suggested. It should allow you to avoid the split brain situation where
the hardware is configured by both the kernel and an external tool.
next prev parent reply other threads:[~2023-08-30 15:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 8:54 [PATCH iwl-next v2] ice: Disable Cage Max Power override Wojciech Drewek
2023-08-24 9:38 ` Przemek Kitszel
2023-08-24 15:32 ` Jakub Kicinski
2023-08-25 11:01 ` Drewek, Wojciech
2023-08-26 0:54 ` Jakub Kicinski
2023-08-27 8:47 ` Ido Schimmel
2023-08-29 9:12 ` Drewek, Wojciech
2023-08-30 15:17 ` Ido Schimmel [this message]
2023-09-01 13:34 ` Drewek, Wojciech
2023-09-12 14:26 ` Ido Schimmel
2023-09-15 13:15 ` Drewek, Wojciech
2023-09-21 12:09 ` Ido Schimmel
2023-10-05 13:58 ` [Intel-wired-lan] " Drewek, Wojciech
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZO9dhzhK+psufXqS@shredder \
--to=idosch@idosch.org \
--cc=idosch@nvidia.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).