From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9132E6AB2 for ; Wed, 30 Aug 2023 15:42:13 +0000 (UTC) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57D40122; Wed, 30 Aug 2023 08:42:12 -0700 (PDT) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id B75585C0056; Wed, 30 Aug 2023 11:42:11 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 30 Aug 2023 11:42:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1693410131; x=1693496531; bh=Af9RLeZAlBuc5 gc2kiqVFlBa+yCpdvEQfwKLpsa17Gk=; b=uSWomlpkiybUlQfu311Q6zBNpw3BK HYGxFNxHKoZT3+WX+BuFxmbjl5YqFNPXtnUJ0IyZdSj73eAl585roI/26yD9Tva5 QK0CSlelyX5Dvq8fqaFx7wotFrVHSSIpm9GaODi/i5Sb0kqibKjx8l39WsCME8Ui uFLRQoEAtu2i2NOb0K1xxn8fYRi6EayxQCep4QXSjprRu7NInL2RPCxKiM41j0IW VW3dEtkP8KfgeG2hgSfE1U/ymimSHQoKXWrMSYuHa1dNoHsh4th26ZN0Bj/4bjFb zCVOhCveqH3YXOvek90FE3fXZM0vW8HD2GNA4tzHhzTuBvibeN/HMMHQA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudefkedgleefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepkfguohcu ufgthhhimhhmvghluceoihguohhstghhsehiughoshgthhdrohhrgheqnecuggftrfgrth htvghrnhepvddufeevkeehueegfedtvdevfefgudeifeduieefgfelkeehgeelgeejjeeg gefhnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepih guohhstghhsehiughoshgthhdrohhrgh X-ME-Proxy: Feedback-ID: i494840e7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 30 Aug 2023 11:42:10 -0400 (EDT) Date: Wed, 30 Aug 2023 18:42:08 +0300 From: Ido Schimmel To: Sriram Yagnaraman Cc: "kuba@kernel.org" , "pabeni@redhat.com" , "netdev@vger.kernel.org" , "linux-kselftest@vger.kernel.org" , "David S . Miller" , Eric Dumazet , David Ahern , Ido Schimmel , Shuah Khan , Petr Machata Subject: Re: [PATCH net v3 3/3] selftests: fib_tests: Add multipath list receive tests Message-ID: References: <20230828113221.20123-1-sriram.yagnaraman@est.tech> <20230828113221.20123-4-sriram.yagnaraman@est.tech> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Wed, Aug 30, 2023 at 09:17:22AM +0000, Sriram Yagnaraman wrote: > If it is OK with all of you here, should I try to improve this test to verify TCP resets don't happen when the nexthop is in a multipath group, perhaps using iperf3? I can send another patch if/when I get something working. Yes, just make sure it's stable. That is, the test reliably fails without the fixes and reliably passes with the fixes.