netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Saeed Mahameed <saeed@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Leon Romanovsky <leon@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, Dima Chumak <dchumak@nvidia.com>,
	Jiri Pirko <jiri@resnulli.us>, Jonathan Corbet <corbet@lwn.net>,
	linux-doc@vger.kernel.org, netdev@vger.kernel.org,
	Saeed Mahameed <saeedm@nvidia.com>,
	Steffen Klassert <steffen.klassert@secunet.com>,
	Simon Horman <simon.horman@corigine.com>
Subject: Re: [PATCH net-next v3 0/8] devlink: Add port function attributes
Date: Mon, 21 Aug 2023 13:41:47 -0700	[thread overview]
Message-ID: <ZOPMCwKk88AzZgKJ@x130> (raw)
In-Reply-To: <20230818143240.3960be87@kernel.org>

On 18 Aug 14:32, Jakub Kicinski wrote:
>On Fri, 18 Aug 2023 21:36:40 +0300 Leon Romanovsky wrote:
>> > and you have to audacity to call the basic rules we had for a very long
>> > time "very strange".
>>
>> This rule relies on basic contract of 1 series -> fast review/acceptance.
>> Once fast review/acceptance doesn't happen, what else do you expect from me?
>
>Since you don't understand what I'm asking please let Saeed post
>your patches.
>

I usually try to avoid posting API changes as part of my pure mlx5 PRs. So
they get their fare share of focused review.

I prefer if such standalone patchsets to be submitted individually, as
they are mostly introducing new devlink knobs. This one isn't a new series
hence the V3, so I am not sure I can agree with the parallel submissions issue
here.

For the two ipsec UDP and TCP selector patches [1] I agree they should've been
part of my PRs.

[1] https://patchwork.kernel.org/project/netdevbpf/cover/cover.1691521680.git.leonro@nvidia.com/

I will take them to my next PR.

Thanks,
Saeed.


      reply	other threads:[~2023-08-21 20:41 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-17  9:11 [PATCH net-next v3 0/8] devlink: Add port function attributes Leon Romanovsky
2023-08-17  9:11 ` [PATCH net-next v3 1/8] devlink: Expose port function commands to control IPsec crypto offloads Leon Romanovsky
2023-08-17  9:11 ` [PATCH net-next v3 2/8] devlink: Expose port function commands to control IPsec packet offloads Leon Romanovsky
2023-08-17  9:11 ` [PATCH net-next v3 3/8] net/mlx5: Drop extra layer of locks in IPsec Leon Romanovsky
2023-08-17  9:11 ` [PATCH net-next v3 4/8] net/mlx5e: Rewrite IPsec vs. TC block interface Leon Romanovsky
2023-08-17  9:11 ` [PATCH net-next v3 5/8] net/mlx5: Add IFC bits to support IPsec enable/disable Leon Romanovsky
2023-08-17  9:11 ` [PATCH net-next v3 6/8] net/mlx5: Provide an interface to block change of IPsec capabilities Leon Romanovsky
2023-08-17  9:11 ` [PATCH net-next v3 7/8] net/mlx5: Implement devlink port function cmds to control ipsec_crypto Leon Romanovsky
2023-08-17  9:11 ` [PATCH net-next v3 8/8] net/mlx5: Implement devlink port function cmds to control ipsec_packet Leon Romanovsky
2023-08-18  3:07 ` [PATCH net-next v3 0/8] devlink: Add port function attributes Jakub Kicinski
2023-08-18  4:19   ` Leon Romanovsky
2023-08-18 16:38     ` Jakub Kicinski
2023-08-18 18:36       ` Leon Romanovsky
2023-08-18 21:32         ` Jakub Kicinski
2023-08-21 20:41           ` Saeed Mahameed [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZOPMCwKk88AzZgKJ@x130 \
    --to=saeed@kernel.org \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=dchumak@nvidia.com \
    --cc=edumazet@google.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=leon@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=saeedm@nvidia.com \
    --cc=simon.horman@corigine.com \
    --cc=steffen.klassert@secunet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).