From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8788F8479 for ; Tue, 22 Aug 2023 10:39:44 +0000 (UTC) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38CFDFB; Tue, 22 Aug 2023 03:39:42 -0700 (PDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id BD2B2320092E; Tue, 22 Aug 2023 06:39:33 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 22 Aug 2023 06:39:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1692700773; x=1692787173; bh=TYcehPDeyWrpL ZI5nP9k0xeqXJO/gx+RoM3vlGRe1m0=; b=vxFbAE0yutGX+jZWygqwFfC9EQ3z/ CqINau8nxSRe0lN/K161c5bu3rDwH+4jaxorjkcUrp/Qqgl1P8WGj2q0EiEE9Pi7 hoYHiPNJh9KcL5Z+7mAgFh9VYj6fljpMxXSy2GpRyMERKZavPUop8gmcdz8qkwjT 8JhniTUCSeB54rNgo+S/Ya2NSzWGngky5cwBxlQGNd3M3gm9lLJxkNR+Ku461nGw cDhfkB0AeZ5PVKYNkH3+YBjqmM4dm01cqhLAePed6H+x/whs4rqZqWBxiAOdNAb8 1EAWlqs2AqQES93sqBfXpHiMBMc6dJKTBD/LT6xICvU+DMCkROfqJDxNg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedruddvuddgfedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvvefukfhfgggtuggjsehttd ertddttddvnecuhfhrohhmpefkughoucfutghhihhmmhgvlhcuoehiughoshgthhesihgu ohhstghhrdhorhhgqeenucggtffrrghtthgvrhhnpedvudefveekheeugeeftddvveefgf duieefudeifefgleekheegleegjeejgeeghfenucevlhhushhtvghrufhiiigvpedtnecu rfgrrhgrmhepmhgrihhlfhhrohhmpehiughoshgthhesihguohhstghhrdhorhhg X-ME-Proxy: Feedback-ID: i494840e7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 22 Aug 2023 06:39:31 -0400 (EDT) Date: Tue, 22 Aug 2023 13:39:27 +0300 From: Ido Schimmel To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, syzbot+5ba06978f34abb058571@syzkaller.appspotmail.com, wg@grandegger.com, mkl@pengutronix.de, idosch@nvidia.com, lucien.xin@gmail.com, xemul@parallels.com, socketcan@hartkopp.net, linux-can@vger.kernel.org Subject: Re: [PATCH net] net: validate veth and vxcan peer ifindexes Message-ID: References: <20230819012602.239550-1-kuba@kernel.org> <20230821104844.19dd4563@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230821104844.19dd4563@kernel.org> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Mon, Aug 21, 2023 at 10:48:44AM -0700, Jakub Kicinski wrote: > On Sun, 20 Aug 2023 19:08:13 +0300 Ido Schimmel wrote: > > There is another report here [1] with a reproducer [2]. Even with this > > patch, the reproducer can still trigger the warning on net-next. Don't > > we also need to reject a negative ifindex in the ancillary header? At > > least with the following diff the warning does not trigger anymore: > > Yeah, definitely, please go ahead and submit. Sure, will submit tomorrow morning. > Is "ancillary header" used more commonly as a term? in gnel we usually > call this thing "user header" or "fixed header". I honestly don't know. IIRC I saw David using the term a few years ago and decided to adopt it.