From: Jiri Bohac <jbohac@suse.cz>
To: Alex Henrie <alexhenrie24@gmail.com>
Cc: Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, benoit.boissinot@ens-lyon.org,
davem@davemloft.net, hideaki.yoshifuji@miraclelinux.com,
dsahern@kernel.org
Subject: Re: [PATCH] ipv6/addrconf: clamp preferred_lft to the minimum instead of erroring
Date: Wed, 23 Aug 2023 10:36:23 +0200 [thread overview]
Message-ID: <ZOXFBzRO98sL5xeV@dwarf.suse.cz> (raw)
In-Reply-To: <CAMMLpeRR_JmFp3DnDJbYdjxnpfxLke-z5KW=EA8_H_xj3FzXvg@mail.gmail.com>
On Tue, Aug 22, 2023 at 09:41:37PM -0600, Alex Henrie wrote:
> "Fixes: eac55bf97094f6b64116426864cf4666ef7587bc", correct?
>
> > On Sun, 2023-08-20 at 19:11 -0600, Alex Henrie wrote:
>
> > > @@ -1368,7 +1368,7 @@ static int ipv6_create_tempaddr(struct inet6_ifaddr *ifp, bool block)
> > > * idev->desync_factor if it's larger
> > > */
> > > cnf_temp_preferred_lft = READ_ONCE(idev->cnf.temp_prefered_lft);
> > > - max_desync_factor = min_t(__u32,
> > > + max_desync_factor = min_t(__s64,
> > > idev->cnf.max_desync_factor,
> > > cnf_temp_preferred_lft - regen_advance);
> >
> > It would be better if you describe in the commit message your above
> > fix.
>
> I did mention the underflow problem in the commit message. When I
> split the patch into two patches, it will be even more prominent. What
> more would you like the commit message to say?
>
> > Also possibly using 'long' as the target type (same as
> > 'max_desync_factor') would be more clear.
>
> OK, will change in v2.
This part looks good to me. Sorry for introducing the bug and
thanks for finding it!
--
Jiri Bohac <jbohac@suse.cz>
SUSE Labs, Prague, Czechia
next prev parent reply other threads:[~2023-08-23 8:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 1:11 [PATCH] ipv6/addrconf: clamp preferred_lft to the minimum instead of erroring Alex Henrie
2023-08-22 9:54 ` Paolo Abeni
2023-08-23 3:41 ` Alex Henrie
2023-08-23 3:45 ` David Ahern
2023-08-23 8:36 ` Jiri Bohac [this message]
2023-08-23 11:00 ` Paolo Abeni
2023-08-29 5:44 ` [PATCH v2 0/5] net: ipv6/addrconf: ensure that temporary addresses' preferred lifetimes are in the valid range Alex Henrie
2023-08-29 5:44 ` [PATCH v2 1/5] net: ipv6/addrconf: avoid integer underflow in ipv6_create_tempaddr Alex Henrie
2023-09-01 4:41 ` [PATCH v3] " Alex Henrie
2023-09-01 13:53 ` David Ahern
2023-09-04 6:21 ` patchwork-bot+netdevbpf
2023-08-29 5:44 ` [PATCH v2 2/5] net: ipv6/addrconf: clamp preferred_lft to the maximum allowed Alex Henrie
2023-08-31 8:25 ` Paolo Abeni
2023-08-29 5:44 ` [PATCH v2 3/5] net: ipv6/addrconf: clamp preferred_lft to the minimum required Alex Henrie
2023-08-31 1:28 ` Jakub Kicinski
2023-08-31 5:40 ` Alex Henrie
2023-08-29 5:44 ` [PATCH v2 4/5] Documentation: networking: explain what happens if temp_valid_lft is too small Alex Henrie
2023-08-29 5:44 ` [PATCH v2 5/5] Documentation: networking: explain what happens if temp_prefered_lft is too small or too large Alex Henrie
2023-08-31 8:33 ` Paolo Abeni
2023-10-24 19:40 ` [PATCH resend 1/4] net: ipv6/addrconf: clamp preferred_lft to the maximum allowed Alex Henrie
2023-10-24 19:40 ` [PATCH resend 2/4] net: ipv6/addrconf: clamp preferred_lft to the minimum required Alex Henrie
2023-10-24 19:40 ` [PATCH resend 3/4] Documentation: networking: explain what happens if temp_valid_lft is too small Alex Henrie
2023-10-24 19:40 ` [PATCH resend 4/4] Documentation: networking: explain what happens if temp_prefered_lft is too small or too large Alex Henrie
2023-10-24 19:48 ` [PATCH resend 1/4] net: ipv6/addrconf: clamp preferred_lft to the maximum allowed Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOXFBzRO98sL5xeV@dwarf.suse.cz \
--to=jbohac@suse.cz \
--cc=alexhenrie24@gmail.com \
--cc=benoit.boissinot@ens-lyon.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=hideaki.yoshifuji@miraclelinux.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).