From: Saeed Mahameed <saeed@kernel.org>
To: Rahul Rameshbabu <rrameshbabu@nvidia.com>
Cc: netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Vadim Fedorenko <vadfed@meta.com>,
Kenneth Klette Jonassen <kenneth.jonassen@bridgetech.tv>
Subject: Re: [PATCH net] net/mlx5: Dynamic cyclecounter shift calculation for PTP free running clock
Date: Thu, 24 Aug 2023 13:40:14 -0700 [thread overview]
Message-ID: <ZOfALr40vfTt7RJp@x130> (raw)
In-Reply-To: <20230821230554.236210-1-rrameshbabu@nvidia.com>
On 21 Aug 16:05, Rahul Rameshbabu wrote:
>Use a dynamic calculation to determine the shift value for the internal
>timer cyclecounter that will lead to the highest precision frequency
>adjustments. Previously used a constant for the shift value assuming all
>devices supported by the driver had a nominal frequency of 1GHz. However,
>there are devices that operate at different frequencies. The previous shift
>value constant would break the PHC functionality for those devices.
>
>Reported-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
>Closes: https://lore.kernel.org/netdev/20230815151507.3028503-1-vadfed@meta.com/
>Fixes: 6a4010927562 ("net/mlx5: Update cyclecounter shift value to improve ptp free running mode precision")
>Signed-off-by: Rahul Rameshbabu <rrameshbabu@nvidia.com>
>Tested-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Acked-by: Saeed Mahameed <saeedm@nvidia.com>
I have nothing else in my queue so just go ahead and apply directly to net.
Thanks,
Saeed.
next prev parent reply other threads:[~2023-08-24 20:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 23:05 [PATCH net] net/mlx5: Dynamic cyclecounter shift calculation for PTP free running clock Rahul Rameshbabu
2023-08-23 19:54 ` Jacob Keller
2023-08-23 21:46 ` Rahul Rameshbabu
2023-08-23 23:31 ` Kenneth Klette Jonassen
2023-08-24 8:40 ` Simon Horman
2023-08-24 20:40 ` Saeed Mahameed [this message]
2023-08-25 2:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOfALr40vfTt7RJp@x130 \
--to=saeed@kernel.org \
--cc=davem@davemloft.net \
--cc=kenneth.jonassen@bridgetech.tv \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=rrameshbabu@nvidia.com \
--cc=vadfed@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).