From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3337E20EC for ; Sun, 27 Aug 2023 08:47:10 +0000 (UTC) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB7F6BF for ; Sun, 27 Aug 2023 01:47:08 -0700 (PDT) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id BD0F632004ED; Sun, 27 Aug 2023 04:47:07 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sun, 27 Aug 2023 04:47:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1693126027; x=1693212427; bh=d8FxgVYyitRM8 +FI5tRdQWjZeyVKzL9XUtF8zxAtM9k=; b=WIOhGrO6WGufry9FnWJtQqotIZo68 FaCg1EczRd7BUGhN9NCa/rh4EHokxV6U1nHZ0DiIsJwAnSPTyNnwAamScGEml7bu 8FjtUC74wqhyGEZIiioohwnlQ6VZqgm8N3f5OJWRT7BRxf8parpqSBC/MIMw3iR6 lPKbJcGfx3n4XCQr6qwoqSfoiZmbKw/8jEwQhye014n3sCwTK1Szw/ZokXES2wQ0 2aesc8+WZpChaaELtw3udnnSrhksPWQOTnSOGEuEZwv7N2dE9Boco6i3GZDcaQjG JVA5KHLBrgGfR1Vp/AmedGLIRLRbKgsJ1kY5YqlzBLyA+IQeYd/W12DtA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudefvddgtdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepkfguohcu ufgthhhimhhmvghluceoihguohhstghhsehiughoshgthhdrohhrgheqnecuggftrfgrth htvghrnhepvddufeevkeehueegfedtvdevfefgudeifeduieefgfelkeehgeelgeejjeeg gefhnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepih guohhstghhsehiughoshgthhdrohhrgh X-ME-Proxy: Feedback-ID: i494840e7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 27 Aug 2023 04:47:06 -0400 (EDT) Date: Sun, 27 Aug 2023 11:47:02 +0300 From: Ido Schimmel To: "Drewek, Wojciech" Cc: Jakub Kicinski , "intel-wired-lan@lists.osuosl.org" , "netdev@vger.kernel.org" , "Kitszel, Przemyslaw" , "idosch@nvidia.com" Subject: Re: [PATCH iwl-next v2] ice: Disable Cage Max Power override Message-ID: References: <20230824085459.35998-1-wojciech.drewek@intel.com> <20230824083201.79f79513@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Fri, Aug 25, 2023 at 11:01:07AM +0000, Drewek, Wojciech wrote: > CC: Ido > > > -----Original Message----- > > From: Jakub Kicinski > > Sent: czwartek, 24 sierpnia 2023 17:32 > > To: Drewek, Wojciech > > Cc: intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; Kitszel, Przemyslaw > > Subject: Re: [PATCH iwl-next v2] ice: Disable Cage Max Power override > > > > On Thu, 24 Aug 2023 10:54:59 +0200 Wojciech Drewek wrote: > > > NVM module called "Cage Max Power override" allows to > > > change max power in the cage. This can be achieved > > > using external tools. The responsibility of the ice driver is to > > > go back to the default settings whenever port split is done. > > > This is achieved by clearing Override Enable bit in the > > > NVM module. Override of the max power is disabled so the > > > default value will be used. > > > > Can you say more? We have ETHTOOL_MSG_MODULE_GET / SET, sounds like > > something we could quite easily get ethtool to support? > > So you're suggesting that ethtool could support setting the maximum power in the cage? > Something like: > - new "--set-module" parameter called "power-max" > - new "--get-module" parameters: "power-max-allowed", "power-min-allowed" indicating limitations reported by the HW. > > About the patch itself, it's only about restoration of the default settings upon port split. Those might be overwritten by > Intel's external tools. Can you please explain why this setting needs to be changed in the first place and why it needs to be restored to the default on port split?