From: Hangbin Liu <liuhangbin@gmail.com>
To: Ido Schimmel <idosch@idosch.org>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
David Ahern <dsahern@kernel.org>,
netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Thomas Haller <thaller@redhat.com>
Subject: Re: [Questions] Some issues about IPv4/IPv6 nexthop route
Date: Mon, 28 Aug 2023 15:53:06 +0800 [thread overview]
Message-ID: <ZOxSYqrgndbdL4/M@Laptop-X1> (raw)
In-Reply-To: <ZMKC7jTVF38JAeNb@shredder>
Hi Ido,
I'm back on this question again. Hope you are not too tired on this topic.
Because in you last reply you only answered that we'd better using new nexthop
API (which I'm totally agree) to resolve the consistent of IPv4 and IPv6. New
feature should also go for the new api. But, it always takes a lot years
for the end user using new API (e.g. some users are still using ifcfg).
What I'm asking is how we should deal with the bugs for old API. See my reply
below.
On Thu, Jul 27, 2023 at 05:45:02PM +0300, Ido Schimmel wrote:
> > Since the route are not merged, the nexthop weight is not shown, which
> > make them look like the same for users. For IPv4, the scope is also
> > not shown, which look like the same for users.
>
> The routes are the same, but separate. They do not form a multipath
> route. Weight is meaningless for a non-multipath route.
>
> > But there are 2 issues here:
> > 1. the *type* and *protocol* field are actally ignored
> > 2. when do `ip monitor route`, the info dumpped in fib6_add_rt2node()
> > use the config info from user space. When means `ip monitor` show the
> > incorrect type and protocol
> >
> > So my questions are, should we show weight/scope for IPv4?
Here is the first one. As the weight/scope are not shown, the two separate
routes would looks exactly the same for end user, which makes user confused.
So why not just show the weight/scope, or forbid user to add a non-multipath
route with weight/scope?
>> How to deal the type/proto info missing for IPv6?
What we should do for this bug? The type/proto info are ignored when
merge the IPv6 nexthop entries.
Thanks
Hangbin
>> How to deal with the difference of merging policy for IPv4/IPv6?
>
> In my opinion, if you want consistent behavior between IPv4 and IPv6 for
> multipath routes, then I suggest using the nexthop API. It was merged in
> 5.3 (IIRC) and FRR started using it by default a few years ago. Other
> than a few bugs that were fixed, I don't remember many complaints. Also,
> any nexthop-related features will only be implemented in the nexthop
> API, not in the legacy API. Resilient nexthop groups is one example.
next prev parent reply other threads:[~2023-08-28 7:53 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 8:00 [PATCH net-next] ipv4/fib: send RTM_DELROUTE notify when flush fib Hangbin Liu
2023-07-18 10:19 ` Ido Schimmel
2023-07-18 10:32 ` Ido Schimmel
2023-07-18 14:45 ` David Ahern
2023-07-18 15:58 ` Stephen Hemminger
2023-07-20 7:51 ` Hangbin Liu
2023-07-20 14:29 ` Ido Schimmel
2023-07-21 1:34 ` Hangbin Liu
2023-07-21 4:01 ` David Ahern
2023-07-21 5:46 ` Hangbin Liu
2023-07-23 7:38 ` Ido Schimmel
2023-07-24 8:56 ` Hangbin Liu
2023-07-24 15:48 ` Stephen Hemminger
2023-07-25 8:20 ` Hangbin Liu
2023-07-25 16:36 ` Stephen Hemminger
2023-07-28 13:01 ` Nicolas Dichtel
2023-07-28 15:42 ` David Ahern
2023-08-02 9:10 ` Thomas Haller
2023-08-08 1:44 ` David Ahern
2023-08-08 18:59 ` Benjamin Poirier
2023-09-11 9:50 ` Thomas Haller
2023-09-13 7:58 ` Nicolas Dichtel
2023-09-13 9:54 ` Hangbin Liu
2023-09-13 14:11 ` Nicolas Dichtel
2023-09-13 14:43 ` David Ahern
2023-09-13 14:53 ` Nicolas Dichtel
2023-09-14 15:43 ` Nicolas Dichtel
2023-09-15 3:07 ` David Ahern
2023-09-15 15:54 ` Nicolas Dichtel
2023-09-13 14:41 ` David Ahern
2023-09-15 16:59 ` Stephen Hemminger
2023-07-26 10:17 ` [Questions] Some issues about IPv4/IPv6 nexthop route (was Re: [PATCH net-next] ipv4/fib: send RTM_DELROUTE notify when flush fib) Hangbin Liu
2023-07-26 15:57 ` David Ahern
2023-07-27 4:19 ` [Questions] Some issues about IPv4/IPv6 nexthop route Hangbin Liu
2023-07-27 15:35 ` David Ahern
2023-07-27 14:45 ` [Questions] Some issues about IPv4/IPv6 nexthop route (was Re: [PATCH net-next] ipv4/fib: send RTM_DELROUTE notify when flush fib) Ido Schimmel
2023-08-28 7:53 ` Hangbin Liu [this message]
2023-08-28 15:06 ` [Questions] Some issues about IPv4/IPv6 nexthop route David Ahern
2023-08-29 1:07 ` Hangbin Liu
2023-08-29 1:42 ` David Ahern
2023-08-02 9:06 ` [PATCH net-next] ipv4/fib: send RTM_DELROUTE notify when flush fib Thomas Haller
2023-08-04 8:09 ` Hangbin Liu
2023-08-09 7:06 ` Ido Schimmel
2023-08-09 10:02 ` Hangbin Liu
2023-07-25 14:13 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOxSYqrgndbdL4/M@Laptop-X1 \
--to=liuhangbin@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=idosch@idosch.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stephen@networkplumber.org \
--cc=thaller@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox