Re: [PATCH net-next] macsec: introduce default_async_crypto sysctl

Scott Dial
2023-08-24T17:08:45Z

On 8/24/2023 9:01 AM, Sabrina Dubroca wrote:
> 2023-08-23, 16:22:31 -0400, Scott Dial wrote:
>> AES-NI's implementation of gcm(aes) requires the FPU, so if it's busy the
>> decrypt gets stuck on the cryptd queue, but that queue is not
>> order-preserving.
>
> It should be (per CPU [*]). The queue itself is a linked list, and if we
> have requests on the queue we don't let new requests skip the queue.

My apologies, I'll be the first to admit that I have not tracked all of
the code changes to either the macsec driver or linux-crypto since I
first made the commit. This comment that requests are queued forced me
to review the code again and it appears that the queueing issue was
resolved in v5.2-rc1 with commit 1661131a0479, so I no longer believe we
need the CRYPTO_ALG_ASYNC since v5.2 and going forward.

So, I believe my patch should be reverted from the mainline kernel and
any releases that are still getting maintenance releases -- I believe
v5.4, v5.10, v5.15, and v6.1.

--
Scott Dial
scott@scottdial.com