From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62D189476 for ; Fri, 1 Sep 2023 09:27:25 +0000 (UTC) Received: from pandora.armlinux.org.uk (unknown [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86B2DC0; Fri, 1 Sep 2023 02:27:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=XIusW0m1E8VscwLTOTsY+xzTnz+U+iqdOkrObW70Mt0=; b=CwUh4HPSI5V8fX2wl9V7QYdslm aUYA3b/XXt5Uk8ttQemTxsdN3q/ivypM4BhHwJcPBM/Pi0yP9gg7yKJRYl0/x/cJhEOyvqnomow7d DoUXcs0sj91/q53LN/yUgNaI7fYqQMTPXKLAAjpqufyOW1Mw3FH7m3kGmguRS6ipHXKarO1xFX7I4 g66Wj5j14+BRMxZ1NUV+3uLq4tw/Gj/aSUESVK1d6D4PVNo7RDWmZvjxFeWobppFHLdeL+pKN5EuG YwG1MzSyAFMlnzC477l94HTnDlZDQt3ym8IGzpyYnFJ78hm1FUNhK4+xSJRPV8Eys6nkhQk0XkJ4N lduakg4g==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:57120) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qc0Qt-0003rZ-1p; Fri, 01 Sep 2023 10:27:15 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qc0Qs-0007iJ-IT; Fri, 01 Sep 2023 10:27:14 +0100 Date: Fri, 1 Sep 2023 10:27:14 +0100 From: "Russell King (Oracle)" To: Radu Pirea Cc: "atenart@kernel.org" , "Radu-nicolae Pirea (OSS)" , "sd@queasysnail.net" , "andrew@lunn.ch" , "hkallweit1@gmail.com" , "davem@davemloft.net" , Sebastian Tobuschat , "linux-kernel@vger.kernel.org" , "pabeni@redhat.com" , "richardcochran@gmail.com" , "edumazet@google.com" , "kuba@kernel.org" , "netdev@vger.kernel.org" Subject: Re: [RFC net-next v2 5/5] net: phy: nxp-c45-tja11xx: implement mdo_insert_tx_tag Message-ID: References: <20230824091615.191379-1-radu-nicolae.pirea@oss.nxp.com> <20230824091615.191379-6-radu-nicolae.pirea@oss.nxp.com> <5d42d6c9-2f0c-8913-49ec-50a25860c49f@oss.nxp.com> <518c11e9000f895fddb5b3dc4d5b2bf445cf320f.camel@nxp.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <518c11e9000f895fddb5b3dc4d5b2bf445cf320f.camel@nxp.com> Sender: Russell King (Oracle) X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,RDNS_NONE, SPF_HELO_NONE,SPF_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Fri, Sep 01, 2023 at 09:09:06AM +0000, Radu Pirea wrote: > On Wed, 2023-08-30 at 13:35 +0200, Sabrina Dubroca wrote: > ... > > > And it's not restored when the link goes back up? That's inconvenient > > :/ > > Do we end up with inconsistent state? ie driver and core believe > > everything is still offloaded, but HW lost all state? do we leak > > some resources allocated by the driver? > > Yes. We end up with inconsistent state. The HW will lost all state when > the phy is reseted. No resource is leaked, everything is there, but the > configuration needs to be reapplied. If it's happening because the PHY is being re-attached from the network driver, then wouldn't it be a good idea to synchronise the hardware state with the software configuration in the ->config_init function? Presumably the hardware state is also lost when resuming from suspend as well? If so, that'll also fix that issue as well. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!