From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA652846B for ; Fri, 1 Sep 2023 13:58:12 +0000 (UTC) Received: from us-smtp-delivery-44.mimecast.com (unknown [207.211.30.44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7796F10EB for ; Fri, 1 Sep 2023 06:58:11 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-351-8dNE5ybnMmCyUz33TI3oRA-1; Fri, 01 Sep 2023 09:57:52 -0400 X-MC-Unique: 8dNE5ybnMmCyUz33TI3oRA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 010F91817903; Fri, 1 Sep 2023 13:57:47 +0000 (UTC) Received: from hog (unknown [10.45.224.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E15671460FF3; Fri, 1 Sep 2023 13:57:43 +0000 (UTC) Date: Fri, 1 Sep 2023 15:57:42 +0200 From: Sabrina Dubroca To: "Radu Pirea (OSS)" Cc: Radu Pirea , "atenart@kernel.org" , "andrew@lunn.ch" , "linux@armlinux.org.uk" , "hkallweit1@gmail.com" , "davem@davemloft.net" , Sebastian Tobuschat , "linux-kernel@vger.kernel.org" , "pabeni@redhat.com" , "richardcochran@gmail.com" , "edumazet@google.com" , "kuba@kernel.org" , "netdev@vger.kernel.org" Subject: Re: [RFC net-next v2 5/5] net: phy: nxp-c45-tja11xx: implement mdo_insert_tx_tag Message-ID: References: <20230824091615.191379-1-radu-nicolae.pirea@oss.nxp.com> <20230824091615.191379-6-radu-nicolae.pirea@oss.nxp.com> <5d42d6c9-2f0c-8913-49ec-50a25860c49f@oss.nxp.com> <518c11e9000f895fddb5b3dc4d5b2bf445cf320f.camel@nxp.com> <831bc700-a9a2-7eda-e97b-e1d54dc806f9@oss.nxp.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <831bc700-a9a2-7eda-e97b-e1d54dc806f9@oss.nxp.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Spam-Status: No, score=0.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_VALIDITY_RPBL,RDNS_NONE,SPF_HELO_NONE,SPF_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net 2023-09-01, 14:58:12 +0300, Radu Pirea (OSS) wrote: > On 01.09.2023 13:07, Sabrina Dubroca wrote: > > > (the interface was up before) > > > [root@alarm ~]# ip link add link end0 macsec0 type macsec encrypt on > > > offload phy > > > [root@alarm ~]# ip link set end0 down > > > [root@alarm ~]# ip macsec add macsec0 rx port 1 address > > > 00:01:be:be:ef:33 > > > RTNETLINK answers: Operation not supported > > > > Where does that EOPNOTSUPP come from? nxp_c45_mdo_add_rxsc from this > > version of the code can't return that, and macsec_add_rxsc also > > shouldn't at this point. > > This is the source of -EOPNOTSUPP > https://elixir.bootlin.com/linux/latest/source/drivers/net/macsec.c#L1928 Could you check which part of macsec_get_ops is failing? Since macsec_newlink with "offload phy" worked, macsec_check_offload shouldn't fail, so why does macsec_get_ops return NULL? real_dev->phydev was NULL'ed? -- Sabrina