Re: [RFC net-next v2 5/5] net: phy: nxp-c45-tja11xx: implement mdo_insert_tx_tag

Radu Pirea (OSS)
2023-09-01T11:58:25Z

On 01.09.2023 13:07, Sabrina Dubroca wrote:
...
>
>>> And what happens in this case?
>>>     ip link add link eth0 type macsec offload phy
>>>     ip link set eth0 down
>>>     ip macsec add macsec0 rx sci ...
>>>     ip macsec add macsec0 tx sa 0 ...
>>>     # etc
>>>     ip link set eth0 up
>>>
>>> Will offload work with the current code?
>>
>> (the interface was up before)
>> [root@alarm ~]# ip link add link end0 macsec0 type macsec encrypt on
>> offload phy
>> [root@alarm ~]# ip link set end0 down
>> [root@alarm ~]# ip macsec add macsec0 rx port 1 address
>> 00:01:be:be:ef:33
>> RTNETLINK answers: Operation not supported
>
> Where does that EOPNOTSUPP come from? nxp_c45_mdo_add_rxsc from this
> version of the code can't return that, and macsec_add_rxsc also
> shouldn't at this point.

This is the source of -EOPNOTSUPP
https://elixir.bootlin.com/linux/latest/source/drivers/net/macsec.c#L1928

--
Radu P.