From: Jiri Olsa <olsajiri@gmail.com>
To: Eduard Zingerman <eddyz87@gmail.com>
Cc: Jiri Olsa <olsajiri@gmail.com>,
John Fastabend <john.fastabend@gmail.com>,
xukuohai@huawei.com, edumazet@google.com,
cong.wang@bytedance.com, bpf@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH bpf] bpf: sockmap, fix skb refcnt race after locking changes
Date: Sat, 2 Sep 2023 19:28:28 +0200 [thread overview]
Message-ID: <ZPNwvO8ViqLD3MmX@krava> (raw)
In-Reply-To: <d8ba77cfeff26a8d52ef05d1bae43b5ceffd1b83.camel@gmail.com>
On Sat, Sep 02, 2023 at 12:24:01AM +0300, Eduard Zingerman wrote:
SNIP
> > > static void sk_psock_skb_state(struct sk_psock *psock,
> > > @@ -685,9 +691,7 @@ static void sk_psock_backlog(struct work_struct *work)
> > > } while (len);
> > >
> > > skb = skb_dequeue(&psock->ingress_skb);
> > > - if (!ingress) {
> > > - kfree_skb(skb);
> > > - }
> > > + kfree_skb(skb);
> > > }
> > > end:
> > > mutex_unlock(&psock->work_mutex);
> > > --
> > > 2.33.0
> > >
> >
> > there's no crash wit with fix, but I noticed I occasionally get FAIL
> >
>
> Please note this patch:
> https://lore.kernel.org/bpf/20230901031037.3314007-1-xukuohai@huaweicloud.com/
> Which should fix the test in question.
ah right it does, thanks
Tested-by: Jiri Olsa <jolsa@kernel.org>
jirka
>
> > #212/78 sockmap_listen/sockmap Unix test_unix_redir:OK
> > ./test_progs:vsock_unix_redir_connectible:1501: ingress: write: Transport endpoint is not connected
> > vsock_unix_redir_connectible:FAIL:1501
> > ./test_progs:vsock_unix_redir_connectible:1501: egress: write: Transport endpoint is not connected
> > vsock_unix_redir_connectible:FAIL:1501
> > #212/79 sockmap_listen/sockmap VSOCK test_vsock_redir:FAIL
> > #212/80 sockmap_listen/sockhash IPv4 TCP test_insert_invalid:OK
> >
> > no idea if it's related
> >
> > jirka
>
next prev parent reply other threads:[~2023-09-02 17:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 20:21 [PATCH bpf] bpf: sockmap, fix skb refcnt race after locking changes John Fastabend
2023-09-01 21:20 ` Jiri Olsa
2023-09-01 21:24 ` Eduard Zingerman
2023-09-02 17:28 ` Jiri Olsa [this message]
2023-09-02 8:13 ` Xu Kuohai
2023-09-02 9:00 ` Simon Horman
2023-09-04 8:13 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZPNwvO8ViqLD3MmX@krava \
--to=olsajiri@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=cong.wang@bytedance.com \
--cc=eddyz87@gmail.com \
--cc=edumazet@google.com \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=xukuohai@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).