Re: [xdp-hints] [RFC bpf-next 07/23] ice: Support RX hash XDP hint

Alexander Lobakin
2023-09-06T12:05:25Z

From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Date: Tue, 5 Sep 2023 17:42:04 +0200

> On Thu, Aug 24, 2023 at 09:26:46PM +0200, Larysa Zaremba wrote:

[...]

>> */
>> +#define ICE_PTYPES \
>
> ERROR: Macros with complex values should be enclosed in parentheses
> #34: FILE: drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h:676:
> +#define ICE_PTYPES \

[...]

> ERROR: space prohibited before open square bracket '['
> #476: FILE: drivers/net/ethernet/intel/ice/ice_txrx_lib.c:580:
> +#define ICE_PTT_UNUSED_ENTRY(PTYPE) [PTYPE] = 0
>
> total: 2 errors, 0 warnings, 0 checks, 525 lines checked

Those all are FPs. The same "errors" are present in libie. checkpatch
doesn't parse the code like e.g. sparse does and it's not able to
understand every #define black magic we're able to write :D

>
>> +
>> +/* A few supplementary definitions for when XDP hash types do not coincide
>> + * with what can be generated from ptype definitions
>> + * by means of preprocessor concatenation.
>> + */
>> +#define XDP_RSS_L3_NONE XDP_RSS_TYPE_NONE
>> +#define XDP_RSS_L4_NONE XDP_RSS_TYPE_NONE
>> +#define XDP_RSS_TYPE_PAY2 XDP_RSS_TYPE_L2
>> +#define XDP_RSS_TYPE_PAY3 XDP_RSS_TYPE_NONE
>> +#define XDP_RSS_TYPE_PAY4 XDP_RSS_L4
>> +
>> +static const enum xdp_rss_hash_type
>> +ice_ptype_to_xdp_hash[ICE_NUM_DEFINED_PTYPES] = {
>> + ICE_PTYPES
>> +};

[...]

Thanks,
Olek