From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18E00362 for ; Wed, 6 Sep 2023 06:40:51 +0000 (UTC) Received: from pandora.armlinux.org.uk (unknown [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B654BCF6; Tue, 5 Sep 2023 23:40:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=lEKa32vDz9dRLHtkiqwBJfqS+z/ud40G6jgqmrjZXvA=; b=Yvk14RBqPGC7nXQfcqb7XiHuZi eb3DC2GRdqxshCc+KqXsoouVITXuQ6FUZKqwatwkrHm8dvS2XMzCjva0xt3kij2fS06x8Ngi0zMH5 HsAhHlA5mzGgnywW593Ukc8DPPyGUrsbk7BqUFpP47K4hua6U2rxg/IuZ6nldsC1v7BwW1vsLasSD CjiCIsbm4VzSEtnPxt/dsRb7dZRyKUN9wuE5vyFY7YZ9qUBDbgsmKfSc+37l5Qx7rI4/6RuSpW3gz d1msfTMk9d/Aqy0RC+fkL6hixKC3dejD9ly7MLQBr+KhV3ia0loqT/lBRR/tX8YNBK0uzngUvxTmu sL1T4XXg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:52998) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qdmD8-0000Fd-38; Wed, 06 Sep 2023 07:40:23 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qdmD6-0004Xt-8o; Wed, 06 Sep 2023 07:40:20 +0100 Date: Wed, 6 Sep 2023 07:40:20 +0100 From: "Russell King (Oracle)" To: Vladimir Oltean Cc: Lukasz Majewski , Tristram.Ha@microchip.com, Eric Dumazet , Andrew Lunn , davem@davemloft.net, Woojung Huh , Oleksij Rempel , Florian Fainelli , Jakub Kicinski , Paolo Abeni , UNGLinuxDriver@microchip.com, Heiner Kallweit , Michael Walle , Horatiu Vultur , Arun Ramadoss , Oleksij Rempel , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [net v4] net: phy: Provide Module 4 KSZ9477 errata (DS80000754C) Message-ID: References: <20230905093315.784052-1-lukma@denx.de> <20230905222945.h7tuzlraxdp5imbh@skbuf> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230905222945.h7tuzlraxdp5imbh@skbuf> Sender: Russell King (Oracle) X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RDNS_NONE,SPF_HELO_NONE, SPF_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Wed, Sep 06, 2023 at 01:29:45AM +0300, Vladimir Oltean wrote: > It's probably not causing practical harm, but currently, we tell > genphy_config_eee_advert() to include reserved bits of the MMD EEE > Advertising Register (MMD 0x07 : 0x3C) into its modification mask. Ah, you've fallen into that trap. genphy_config_eee_advert() is obsolete and redundant. Nothing calls it, and it should be removed. What's actually used is genphy_c45_an_config_eee_aneg() and genphy_c45_write_eee_adv(). The latter will not modify any reserved bits in the register. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!